[codex] remove exam manifest architecture#1640
Merged
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 21 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (90)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
TSavo
force-pushed
the
codex/acquaint-20260529-115526
branch
from
9ecb755 to
ca671e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the exam-manifest architecture end to end now that the shared concept-hub vocabulary model is gone.
Why
The exam model was dead code after the shared vocabulary/concept-hub removal. Keeping it around made the system advertise and pin a capability that no longer has a valid role.
Validation
Post-final-rebase checks:
git diff --checkpnpm vitest run implementations/typescript/src/legacy-ontology-removal.test.tsconfig.toml/manifest.tomlgrep for legacy exam identifiers: cleanLonger local checks run before the final one-commit rebase:
python3 -m pytest implementations/python/provekit-lift-python-source/tests- 91 passedmvn -pl provekit-lift-java-source -am test- build success, 52 source-module tests plus reactor depscargo test --manifest-path menagerie/smoke-test-e2e/driver/Cargo.toml- 1 passedCARGO_BUILD_JOBS=2 cargo test -p provekit-cli --test cmd_materialize_integration- 20 passed after installing the TypeScript better-sqlite3 kit depsCARGO_BUILD_JOBS=2 cargo test -p provekit-cli --test library_tag_dispatch_test- 2 passed after installing the TypeScript pg kit depsThe full Rust package command was intentionally stopped after it began a second long rerun; the first full run reached the TypeScript kit dependency gaps above, those were fixed locally with
npm ciin the affected kit dirs, and the failed tests were rerun directly.