Add Java AssertJ emit and lift kits#1634
Conversation
|
Warning Review limit reached
More reviews will be available in 54 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87a0d52b52
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| List<String> decls = new ArrayList<>(); | ||
| for (String v : vars) { | ||
| String type = declaredTypes.getOrDefault(v, fallbackType); | ||
| decls.add(type + " " + v + " = " + defaultValueFor(type) + ";"); |
There was a problem hiding this comment.
Choose placeholders that satisfy emitted assertions
For emitted predicates that rely on generated placeholders, every numeric variable is initialized to 0 and every reference to null, so supported contracts such as ne(a,b), lt(a,b), or option-is-some(o) produce tests like assertThat(a).isNotEqualTo(b) with a == b == 0 or assertThat(o).isNotNull() with o == null. Those sources compile, but provekit.plugin.check runs mvn -q test, so common emitted AssertJ contracts fail immediately instead of validating the emission artifact.
Useful? React with 👍 / 👎.
87a0d52 to
432457a
Compare
432457a to
46e93dd
Compare
Summary
provekit-emit-java-assertjandprovekit-lift-java-assertjas separate Java artifactsVerification
mvn -B -ntp -pl provekit-emit-java-assertj,provekit-lift-java-assertj -am -Dtest=AssertJEmitterTest,RpcServerDescribeTest,AssertJExtractorTest packagegit diff --checkNotes: