Skip to content

Add Java AssertJ emit and lift kits#1634

Merged
TSavo merged 1 commit into
mainfrom
codex/java-assertj-artifact-20260529
May 29, 2026
Merged

Add Java AssertJ emit and lift kits#1634
TSavo merged 1 commit into
mainfrom
codex/java-assertj-artifact-20260529

Conversation

@TSavo
Copy link
Copy Markdown
Owner

@TSavo TSavo commented May 29, 2026

Summary

  • add provekit-emit-java-assertj and provekit-lift-java-assertj as separate Java artifacts
  • register AssertJ emit and lift surfaces through project config and manifests
  • emit native AssertJ fluent assertions from normalized predicates
  • lift ordinary AssertJ fluent assertions from JUnit tests without ProveKit markers
  • keep unsupported predicates/forms honest instead of minting fake contracts

Verification

  • mvn -B -ntp -pl provekit-emit-java-assertj,provekit-lift-java-assertj -am -Dtest=AssertJEmitterTest,RpcServerDescribeTest,AssertJExtractorTest package
  • TOML parse check for Java project config and AssertJ emit/lift manifests
  • git diff --check

Notes:

  • No Rust CLI code is changed in this PR.
  • Maven prints existing shade warnings; the targeted reactor build passes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@TSavo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 54 minutes and 12 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 64fd86ed-b37a-4d53-a0dd-ec5d6e7b54ab

📥 Commits

Reviewing files that changed from the base of the PR and between 5e7427b and 46e93dd.

📒 Files selected for processing (17)
  • implementations/java/.provekit/config.toml
  • implementations/java/.provekit/emit/java-assertj/manifest.toml
  • implementations/java/.provekit/lift/java-assertj/manifest.toml
  • implementations/java/pom.xml
  • implementations/java/provekit-emit-java-assertj/pom.xml
  • implementations/java/provekit-emit-java-assertj/src/main/java/com/provekit/emit/assertj/AssertJEmitter.java
  • implementations/java/provekit-emit-java-assertj/src/main/java/com/provekit/emit/assertj/EmitPlan.java
  • implementations/java/provekit-emit-java-assertj/src/main/java/com/provekit/emit/assertj/Main.java
  • implementations/java/provekit-emit-java-assertj/src/main/java/com/provekit/emit/assertj/PredicateAssertionTable.java
  • implementations/java/provekit-emit-java-assertj/src/main/java/com/provekit/emit/assertj/RpcServer.java
  • implementations/java/provekit-emit-java-assertj/src/main/java/com/provekit/emit/assertj/TermRenderer.java
  • implementations/java/provekit-emit-java-assertj/src/test/java/com/provekit/emit/assertj/AssertJEmitterTest.java
  • implementations/java/provekit-emit-java-assertj/src/test/java/com/provekit/emit/assertj/RpcServerDescribeTest.java
  • implementations/java/provekit-lift-java-assertj/pom.xml
  • implementations/java/provekit-lift-java-assertj/src/main/java/com/provekit/lift/assertj/AssertJExtractor.java
  • implementations/java/provekit-lift-java-assertj/src/main/resources/META-INF/services/com.provekit.lift.Extractor
  • implementations/java/provekit-lift-java-assertj/src/test/java/com/provekit/lift/assertj/AssertJExtractorTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/java-assertj-artifact-20260529

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87a0d52b52

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

List<String> decls = new ArrayList<>();
for (String v : vars) {
String type = declaredTypes.getOrDefault(v, fallbackType);
decls.add(type + " " + v + " = " + defaultValueFor(type) + ";");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Choose placeholders that satisfy emitted assertions

For emitted predicates that rely on generated placeholders, every numeric variable is initialized to 0 and every reference to null, so supported contracts such as ne(a,b), lt(a,b), or option-is-some(o) produce tests like assertThat(a).isNotEqualTo(b) with a == b == 0 or assertThat(o).isNotNull() with o == null. Those sources compile, but provekit.plugin.check runs mvn -q test, so common emitted AssertJ contracts fail immediately instead of validating the emission artifact.

Useful? React with 👍 / 👎.

@TSavo TSavo force-pushed the codex/java-assertj-artifact-20260529 branch from 87a0d52 to 432457a Compare May 29, 2026 19:04
@TSavo TSavo force-pushed the codex/java-assertj-artifact-20260529 branch from 432457a to 46e93dd Compare May 29, 2026 19:09
@TSavo TSavo merged commit 102a124 into main May 29, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant