Skip to content

Add Java TestNG emit kit#1633

Merged
TSavo merged 1 commit into
mainfrom
codex/java-testng-emitter-20260529-104731
May 29, 2026
Merged

Add Java TestNG emit kit#1633
TSavo merged 1 commit into
mainfrom
codex/java-testng-emitter-20260529-104731

Conversation

@TSavo
Copy link
Copy Markdown
Owner

@TSavo TSavo commented May 29, 2026

Summary

  • add provekit-emit-java-testng as a separate Java emitter artifact
  • register java-testng through project config and emit manifest
  • emit native TestNG source using org.testng.annotations.Test and org.testng.Assert
  • report unsupported predicates with incomplete status
  • add Rust CLI integration coverage for config/manifest/RPC dispatch only

Verification

  • mvn -B -ntp -pl provekit-emit-java-testng -am package
  • cargo test -p provekit-cli --test cmd_emit_java_testng --manifest-path implementations/rust/Cargo.toml emit_java_testng_dispatches_real_emitter_and_maven_checks_output -- --nocapture
  • cargo fmt --manifest-path implementations/rust/provekit-cli/Cargo.toml --check
  • git diff --check

Note: Maven prints the existing reactor warnings for provekit-lift-java-term-shape and the normal shade MANIFEST overlap warning; the build passes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@TSavo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 55 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7963fcbf-c303-4800-95d2-b02f83697aeb

📥 Commits

Reviewing files that changed from the base of the PR and between ff19472 and d6099b4.

📒 Files selected for processing (15)
  • implementations/java/.provekit/config.toml
  • implementations/java/.provekit/emit/java-testng/manifest.toml
  • implementations/java/pom.xml
  • implementations/java/provekit-emit-java-testng/pom.xml
  • implementations/java/provekit-emit-java-testng/src/main/java/com/provekit/emit/testng/EmitPlan.java
  • implementations/java/provekit-emit-java-testng/src/main/java/com/provekit/emit/testng/Main.java
  • implementations/java/provekit-emit-java-testng/src/main/java/com/provekit/emit/testng/PredicateAssertionTable.java
  • implementations/java/provekit-emit-java-testng/src/main/java/com/provekit/emit/testng/RpcServer.java
  • implementations/java/provekit-emit-java-testng/src/main/java/com/provekit/emit/testng/TermRenderer.java
  • implementations/java/provekit-emit-java-testng/src/main/java/com/provekit/emit/testng/TestNgEmitter.java
  • implementations/java/provekit-emit-java-testng/src/test/java/com/provekit/emit/testng/EndToEndCompileTest.java
  • implementations/java/provekit-emit-java-testng/src/test/java/com/provekit/emit/testng/PredicateAssertionTableTest.java
  • implementations/java/provekit-emit-java-testng/src/test/java/com/provekit/emit/testng/RpcServerDescribeTest.java
  • implementations/java/provekit-emit-java-testng/src/test/java/com/provekit/emit/testng/TestNgEmitterTest.java
  • implementations/rust/provekit-cli/tests/cmd_emit_java_testng.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/java-testng-emitter-20260529-104731

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6099b4224

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +90 to +92
for (String v : vars) {
String type = declaredTypes.getOrDefault(v, fallbackType);
decls.add(type + " " + v + " = " + defaultValueFor(type) + ";");
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Generate placeholders that satisfy executed TestNG assertions

When a plan contains supported predicates beyond the all-zero cases, these per-variable defaults make the emitted TestNG methods fail at runtime even though the emission reports is_complete: e.g. ne, lt, and gt declare both operands as 0, option-is-some/not-null declare Object ... = null, and fallible-err gets a non-throwing null value. Since this kit's compile check actually runs mvn -q test in RpcServer.checkResult, provekit emit --compile-check fails for contracts the plugin advertises as supported; the placeholders need to be chosen per predicate/argument (as the other emitters do) or these predicates should be left unsupported.

Useful? React with 👍 / 👎.

@TSavo TSavo merged commit 6911319 into main May 29, 2026
2 of 6 checks passed
@TSavo TSavo deleted the codex/java-testng-emitter-20260529-104731 branch May 29, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant