Skip to content

Add Python unittest emit kit#1630

Merged
TSavo merged 1 commit into
mainfrom
codex/python-unittest-emitter-20260529
May 29, 2026
Merged

Add Python unittest emit kit#1630
TSavo merged 1 commit into
mainfrom
codex/python-unittest-emitter-20260529

Conversation

@TSavo
Copy link
Copy Markdown
Owner

@TSavo TSavo commented May 29, 2026

Summary

  • add provekit-emit-python-unittest as a separate Python emitter artifact
  • emit native unittest.TestCase tests and assertions from normalized predicates
  • report unsupported predicates honestly with incomplete status
  • add Rust CLI integration coverage for config/manifest/RPC dispatch only

Verification

  • PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=implementations/python/provekit-emit-python-unittest/src python3 -m pytest -p no:cacheprovider implementations/python/provekit-emit-python-unittest/tests -q
  • PYTHONDONTWRITEBYTECODE=1 cargo test --manifest-path implementations/rust/Cargo.toml -p provekit-cli --test cmd_emit_python_unittest -- --nocapture
  • cargo fmt --manifest-path implementations/rust/provekit-cli/Cargo.toml --check
  • git diff --check

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@TSavo, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 22 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dd4ba35f-7723-4ecc-b015-c5dd68fe6357

📥 Commits

Reviewing files that changed from the base of the PR and between ff19472 and 41528ad.

📒 Files selected for processing (13)
  • implementations/python/provekit-emit-python-unittest/README.md
  • implementations/python/provekit-emit-python-unittest/pyproject.toml
  • implementations/python/provekit-emit-python-unittest/src/provekit_emit_python_unittest/__init__.py
  • implementations/python/provekit-emit-python-unittest/src/provekit_emit_python_unittest/__main__.py
  • implementations/python/provekit-emit-python-unittest/src/provekit_emit_python_unittest/emitter.py
  • implementations/python/provekit-emit-python-unittest/src/provekit_emit_python_unittest/plugin_memento.py
  • implementations/python/provekit-emit-python-unittest/src/provekit_emit_python_unittest/predicate_table.py
  • implementations/python/provekit-emit-python-unittest/src/provekit_emit_python_unittest/rpc.py
  • implementations/python/provekit-emit-python-unittest/tests/test_emitter.py
  • implementations/python/provekit-emit-python-unittest/tests/test_end_to_end.py
  • implementations/python/provekit-emit-python-unittest/tests/test_predicate_table.py
  • implementations/python/provekit-emit-python-unittest/tests/test_rpc.py
  • implementations/rust/provekit-cli/tests/cmd_emit_python_unittest.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/python-unittest-emitter-20260529

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41528add96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +23 to +25
if name.startswith(_CONCEPT_PREFIX):
return name[len(_CONCEPT_PREFIX):]
return name
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Normalize canonical predicate symbols

When the EmitPlan contains canonical neutral atom names such as =, <, or , this returns the symbol unchanged, but _HANDLERS only contains the sugar names (eq, lt, le, etc.), so those supported predicates are reported as unsupported and the CLI exits incomplete for normal harvester output. The Rust emitter documents that the harvester emits canonical math symbols (implementations/rust/provekit-emit-rust-cargo-test/src/lib.rs:103-111), and provekit emit forwards the plan to the kit unchanged, so this unittest kit needs the same symbol-to-head normalization before lookup.

Useful? React with 👍 / 👎.

@TSavo TSavo merged commit 74d0ca0 into main May 29, 2026
5 of 6 checks passed
@TSavo TSavo deleted the codex/python-unittest-emitter-20260529 branch May 29, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant