Add Python unittest emit kit#1630
Conversation
|
Warning Review limit reached
More reviews will be available in 58 minutes and 22 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 41528add96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if name.startswith(_CONCEPT_PREFIX): | ||
| return name[len(_CONCEPT_PREFIX):] | ||
| return name |
There was a problem hiding this comment.
Normalize canonical predicate symbols
When the EmitPlan contains canonical neutral atom names such as =, <, or ≤, this returns the symbol unchanged, but _HANDLERS only contains the sugar names (eq, lt, le, etc.), so those supported predicates are reported as unsupported and the CLI exits incomplete for normal harvester output. The Rust emitter documents that the harvester emits canonical math symbols (implementations/rust/provekit-emit-rust-cargo-test/src/lib.rs:103-111), and provekit emit forwards the plan to the kit unchanged, so this unittest kit needs the same symbol-to-head normalization before lookup.
Useful? React with 👍 / 👎.
Summary
provekit-emit-python-unittestas a separate Python emitter artifactunittest.TestCasetests and assertions from normalized predicatesVerification
PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=implementations/python/provekit-emit-python-unittest/src python3 -m pytest -p no:cacheprovider implementations/python/provekit-emit-python-unittest/tests -qPYTHONDONTWRITEBYTECODE=1 cargo test --manifest-path implementations/rust/Cargo.toml -p provekit-cli --test cmd_emit_python_unittest -- --nocapturecargo fmt --manifest-path implementations/rust/provekit-cli/Cargo.toml --checkgit diff --check