Skip to content

moved to newer version of clang - #192

Merged
pjljvandelaar merged 1 commit into
mainfrom
173-wait-until-clang-is-updated-might-take-years-or-replace-it-with-another-package
Sep 16, 2026
Merged

pjljvandelaar merged 1 commit into
mainfrom
173-wait-until-clang-is-updated-might-take-years-or-replace-it-with-another-package

Conversation

@pjljvandelaar

@pjljvandelaar pjljvandelaar commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Fixes applied:

  • Removed clang as dependency - keeping only libclang-ng==22.1.4.2 as it also includes the language bindings.
  • Fixed clang_ast_node.py — File objects are no longer hashable in newer bindings; changed _collect_expansions to use child.extent.start.file.name (string) instead of the raw File object.
  • Added _CRT_USE_BUILTIN_OFFSETOF to the existing SYSTEM_MACROS allowlist (newer clang surfaces this predefined macro as an AST child; the file already had this exact filtering mechanism for other builtins).
  • Updated 8 expected strings in test_c_pattern_factory.py — newer clang now populates Cursor.spelling for binary operators (e.g. <=, ==) where it used to return ""; this is an intentional upstream improvement (there was already a TODO comment anticipating it), so the test expectations needed updating, not the source.

@pjljvandelaar
pjljvandelaar merged commit 9c17aeb into main Sep 16, 2026
8 checks passed
@pjljvandelaar
pjljvandelaar deleted the 173-wait-until-clang-is-updated-might-take-years-or-replace-it-with-another-package branch September 16, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wait until Clang is updated (might take years) or replace it with another package

1 participant