camelCase and snake_case changes - #147
Merged
Merged
Conversation
FrancescoPezzella
added
bug
FrancescoPezzella
marked this pull request as ready for review
September 8, 2026 11:36
Collaborator
|
Is the conversion behaviour the same as https://pypi.org/project/camel-converter/? If so, that is fine! If not, please document the differences! |
Collaborator
|
I think a design or implementation decision record would be more appropriate. That is something for later! |
pjljvandelaar
approved these changes
Sep 9, 2026
pjljvandelaar
left a comment
pjljvandelaar
left a comment
Collaborator
There was a problem hiding this comment.
Nice job!
Just some minor remarks - if you make these changes nice, if not I will merge when the other reviewers also have approved.
… small changes to formating
QuinnCarisCapgemini
approved these changes
Sep 10, 2026
Collaborator
Author
|
This MR has 2 approvals, can it be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to issue #146