Fix LookSAM gv state key mismatch and float alpha handling - #19
Open
kabishou11 wants to merge 1 commit into
Open
kabishou11 wants to merge 1 commit into
kabishou11 wants to merge 1 commit into
Conversation
compute_gv looked up 'old_grad' while sam_perturb_weights stores 'old_g', so gv was never written and non-k steps skipped apply_gv. Also accept Python-float alpha in apply_gv instead of calling .to().
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18.
LookSAM's periodic vertical-component path was dead on
main:sam_perturb_weightsstores the first-order gradient understate[p]['old_g'], butcompute_gvlooked upold_grad, sogvwas never written and non-ksteps skippedapply_gv(silent degrade to plain SGD between refreshes).alpha=0.7hitself.alpha.to(p)and raisedAttributeError.Changes
old_gincompute_gv(with a short comment tying it tosam_perturb_weights).alphainapply_gv.mainand pass after the fix.Test plan
pytest tests/optim/test_looksam_gv.py tests/optim/test_geometry_reshaping.py -v