Relax Hessian dataloader batch unpacking for common formats - #17
Open
kabishou11 wants to merge 1 commit into
Open
kabishou11 wants to merge 1 commit into
kabishou11 wants to merge 1 commit into
Conversation
dataloader_hv_product previously required a 3-tuple (index, inputs, targets), so standard PyTorch (inputs, targets) DataLoaders raised ValueError. Add unpack_batch that accepts 2-tuples, legacy 3-tuples, and simple dict batches, and cover both paths with unit tests. Fixes THUDM#10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10.
hessian.dataloader_hv_producthard-codedfor _, inputs, targets in self.data, so the common PyTorch(inputs, targets)DataLoader convention raisedValueError: too many values to unpack.Add
unpack_batchthat accepts:(inputs, targets)pairs(index, inputs, targets)tripletsinputs/targets(orinput/target)Test plan
uv run --with pytest pytest -q tests/test_hessian_batch_unpack.py— 4 passed