[chore] 운영 서버 종료 및 개발 서버 단일화#362
Conversation
Walkthrough
ChangesCD 워크플로우 배포 방식 변경
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Results488 tests 488 ✅ 45s ⏱️ Results for commit 01110f8. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/cd-workflow-dev.yml:
- Around line 79-83: Make the deployment image reference immutable by using a
fixed tag instead of pulling the default latest image in the CD workflow. Update
the image naming flow in the workflow and the deploy.sh handoff so build, push,
pull, and deploy all use the same tag derived from GITHUB_SHA (or another unique
commit-based tag), and ensure the docker pull command in the deployment step
references that exact tag consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 2a43df81-675f-4597-97ed-edeab6a0b5b0
📒 Files selected for processing (1)
.github/workflows/cd-workflow-dev.yml
| echo "🥳 Pulling new image" | ||
| sudo docker pull ${{ secrets.DOCKER_USERNAME }}/${{ secrets.DOCKER_IMAGE }} | ||
|
|
||
| echo "🌱 Starting new container" | ||
| sudo docker-compose up -d | ||
| sudo docker image prune -a -f | ||
|
|
||
| echo "🚀 Run Blue-Green Deploy Script" | ||
| sudo bash deploy.sh |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major
이미지 태그를 불변 값으로 고정하세요. docker pull이 태그 없이 실행돼 동시 CD에서 다른 실행이 푸시한 최신 이미지가 배포될 수 있습니다. GITHUB_SHA 같은 고정 태그를 build/push/pull/deploy.sh 전반에 일관되게 전달하세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/cd-workflow-dev.yml around lines 79 - 83, Make the
deployment image reference immutable by using a fixed tag instead of pulling the
default latest image in the CD workflow. Update the image naming flow in the
workflow and the deploy.sh handoff so build, push, pull, and deploy all use the
same tag derived from GITHUB_SHA (or another unique commit-based tag), and
ensure the docker pull command in the deployment step references that exact tag
consistently.
|
띱은 제 최애 서비스였는데 종료한다니 아쉽네요.. 하.. |
|
서비스 종료 아닙니다 ^^ |
#️⃣ 연관된 이슈
📝 작업 내용
운영 서버를 종료하고 개발 서버 하나로 통합
도메인을 변경하고, 개발 서버에 블루그린 무중단 배포를 적용
변경 사항
EC2 직접 작업 내역
📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요
Summary by CodeRabbit