feat(conversation-recorder): add webhook support and enhance storage handling#2171
Open
Roei-Bracha wants to merge 3 commits into
Open
feat(conversation-recorder): add webhook support and enhance storage handling#2171Roei-Bracha wants to merge 3 commits into
Roei-Bracha wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces webhook support for upload notifications, fixes prefix path issues for GCS and S3 upload destinations, ensures local recordings are preserved if uploads fail, and resolves a critical race condition.
Important
Critical Bug Fix: Fixes a race condition during initialization. If
start_recordingwas invoked beforeon_start()completed, the event loop (self.loop) remained uninitialized, leading to a failure that could crash/fail the entire conversation pipeline.Changes
start_recordingif it is not already set.manifest.json.PYTHONPATHin test start script to correctly resolve the extension package.