Repository navigation
revert: withdraw the loader-less resident pool publication - #910
Merged
Merged
Conversation
This reverts merge commit d670333 (PR T-Auto#907), which published a PTC preset's allowedTools pool as resident whenever dynamic loading was off. Refs T-Auto#904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
PR #907 made a PTC scope with dynamic loading off publish the configured
allowedToolspool as resident. That answer to #904 is being withdrawn: the behaviour is not the one we want onmain.The change
git revert -m 1 d670333b— one commit, eight files, the exact inverse of the merge.Proof of the inverse:
git diff --stat d670333b^1 8818e09cprints nothing, so every reverted file is byte-identical to its state before #907.src/publication/ptc.tsno longer contains theexposedcomputation.test/modes.test.mjsis back to asserting that a loader-less scope publishes no selectable pool.Deliberately not done here: no replacement behaviour is added. This PR only removes #907, so the follow-up can be designed on its own terms.
Validation
The revert is a pure inverse, so the tree this PR produces is the exact tree CI accepted before #907:
Affected suites, run locally against the reverted tree:
CI — every job on this PR:
The first
validate (darwin-arm64)attempt failed on an exit hang, not an assertion:bench-tools.test.mjsreportedall 12 checks passedand then kept its process alive until the 300 s suite deadline stopped it. The rerun above passed in 4m1s. Nothing in this diff touchestest/orbench/, andmainat the identical commitd670333bpassed the same job in 3m30s, so it is pre-existing harness flakiness rather than a regression from this revert.Environment
main的 commit:d670333bnpm ci --ignore-scripts(本地临时工作树)