Skip to content

revert: withdraw the loader-less resident pool publication - #910

Merged
Nicholas023 merged 1 commit into
T-Auto:mainfrom
Nicholas023:revert-907-ptc-resident
Nov 13, 2026
Merged

Nicholas023 merged 1 commit into
T-Auto:mainfrom
Nicholas023:revert-907-ptc-resident

Conversation

@Nicholas023

@Nicholas023 Nicholas023 commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

What was wrong

PR #907 made a PTC scope with dynamic loading off publish the configured allowedTools pool as resident. That answer to #904 is being withdrawn: the behaviour is not the one we want on main.

The change

git revert -m 1 d670333b — one commit, eight files, the exact inverse of the merge.

Proof of the inverse: git diff --stat d670333b^1 8818e09c prints nothing, so every reverted file is byte-identical to its state before #907.

Deliberately not done here: no replacement behaviour is added. This PR only removes #907, so the follow-up can be designed on its own terms.

Validation

The revert is a pure inverse, so the tree this PR produces is the exact tree CI accepted before #907:

$ git diff --stat d670333b^1 8818e09c
$                              # empty: no difference from the pre-merge tree

$ grep -n "exposed" src/publication/ptc.ts
$                              # empty: the resident-pool computation is gone

$ grep -n "loader-less scope publishes" test/modes.test.mjs
396:    assert.equal(names(agent).includes(publicToolName('write_file')), false, 'a loader-less scope publishes no selectable pool')

Affected suites, run locally against the reverted tree:

$ node test/run.mjs modes
dsh-ops modes: all 12 checks passed
dsh-ops release-tar-modes: all 4 checks passed

$ node test/run.mjs resident-switch
dsh-ops test: 1 suite(s) passed

$ node test/run.mjs ptc-declaration-surface
dsh-ops test: 1 suite(s) passed

$ node test/run.mjs bench-tools
dsh-ops bench-tools: all 12 checks passed   # 6.47s, exit 0

CI — every job on this PR:

CI required          pass   3s
node-floor           pass   3m21s
rust-lint            pass   28s
source-size          pass   6s
tools-trial          pass   47s
validate (darwin-arm64)  pass   4m1s
validate (darwin-x64)    pass   9m0s
validate (linux-x64)     pass   3m25s
validate (win32-x64)     pass   8m4s
workflow-lint        pass   10s

The first validate (darwin-arm64) attempt failed on an exit hang, not an assertion: bench-tools.test.mjs reported all 12 checks passed and then kept its process alive until the 300 s suite deadline stopped it. The rerun above passed in 4m1s. Nothing in this diff touches test/ or bench/, and main at the identical commit d670333b passed the same job in 3m30s, so it is pre-existing harness flakiness rather than a regression from this revert.

Environment

  • OS / 架构:Windows x64
  • Node:v24.21.0
  • 基于上游 main 的 commit:d670333b
  • 安装通道:npm ci --ignore-scripts(本地临时工作树)

This reverts merge commit d670333 (PR T-Auto#907), which published a PTC
preset's allowedTools pool as resident whenever dynamic loading was off.

Refs T-Auto#904
@Nicholas023
Nicholas023 merged commit 88ecc72 into T-Auto:main Nov 13, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant