Skip to content
This repository was archived by the owner on May 4, 2026. It is now read-only.

Ensure protobuf targets build in order and fix Lua include casing#30

Merged
GersonHMG merged 9 commits into
mainfrom
codex/fix-win-deploy.yml-and-cmake-issue
Nov 24, 2025
Merged

Ensure protobuf targets build in order and fix Lua include casing#30
GersonHMG merged 9 commits into
mainfrom
codex/fix-win-deploy.yml-and-cmake-issue

Conversation

@GersonHMG
Copy link
Copy Markdown
Contributor

Summary

  • gate the generated proto library on the ExternalProject protobuf build/install so the first build succeeds
  • ensure the protobuf library target in src/protobuf waits for the external build to finish before Qt autogen runs
  • correct the Lua bindings include to match the lowercase header name on case-sensitive filesystems

Testing

  • cmake --build build --config Release -- -j1

Codex Task

@GersonHMG GersonHMG merged commit 56ee274 into main Nov 24, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant