Adopt mcp-kit 0.3 and delete shared implementations - #34
Merged
Merged
Conversation
Contributor
Author
|
Final-head CI and benchmark run 36793151470 are green. Read back bench.json: fetched 96/105 (866 median tokens, 80.2 ms median), package-only hybrid 60/105 (903 median tokens, 30.8 ms median). Both accuracy gates hold; ranking was not changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Use the published sylphx-mcp-kit 0.3.0 for embeddings, lexical tokenization, star hints and cache roots. Delete local embed.rs, tokenize.rs and star_hint.rs and the cache-root implementation.
Compatibility
Ranking, model choice, opt-out, mirror URL and LOCKDOCS_CACHE layout remain product-owned. semantic.rs is only policy/loading orchestration; all model parsing, downloading, tokenization, quantization and cosine math live upstream. Identifier mode preserves old vectors. Existing model.q8/vocab.txt load directly; persisted Vec8 postcard fields are unchanged and have a compatibility test. No cache format bump or rebuild is needed. Public embed/tokenize module names remain aliases.
Validation
Selected-source rustfmt check, git diff --check, manifest-version check and capability-path check passed. Cargo lockfile resolved the published registry release. No local Rust compiles; full cross-platform CI and the benchmark run in GitHub Actions.
Built by: GPT-6.1. Review: pending