Repository navigation
Conversation
Assigning Mateo starts a first-party workflow that calls the Cursor Cloud Agents API with Grok 4.6 Extra High. The issue stays open until the implementation pull request squash-merges after peer approval. Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
sdcarlson
left a comment
There was a problem hiding this comment.
Request changes on a06a1ae: scripts/ci/launch-sykosyber-agent.mjs shouldSkip trusts any issue comment containing MARKER_PREFIX. A public commenter can post "<!-- relay-sykosyber-agent:anything" before assignment (or merely quote the marker), and subsequent legitimate runs/sweeps skip the issue as already launched even though no agent exists. The independent reviewer reproduced this directly through the exported function.
Only trust an exact dispatch marker from the expected workflow identity, validated for this issue/agent, or verify the deterministic agent id with Cursor before treating it as launched. Add tests proving an outsider marker and quoted/malformed marker cannot suppress dispatch while a genuine workflow launch remains idempotent. Keep the workflow/API permissions constrained.
Current official Cursor v1 docs support the Bearer/model-object/repos/agentId request contract, so those are not findings. Live launch remains unverified without the configured API key. I am continuing review of forced reopening and concurrent launch behavior separately.
|
The marker suppression finding also applies to latest5a9ec0c: the dispatch script is unchanged from reviewed a06a1ae. Please fix and re-request review on a current-main head. No live Cursor launch was performed by this review. |
…ation The Extra High prompt test used String.includes on a GitHub issue URL, which CodeQL flagged as incomplete hostname checks. Match the constructed first line instead. Co-authored-by: sykosyber <sykosyber@users.noreply.github.com>
|
Review status at a879d1c: the reported shouldSkip marker issue remains unchanged. The CodeQL assertion rewrite is useful but does not address arbitrary-comment suppression. Please implement the requested trusted exact-marker regression/fix, then request latest-head review. |
sdcarlson
left a comment
There was a problem hiding this comment.
Verdict
Close this PR. The user problem is "Mateo waits for someone to start Extra High." That is a click, not a product defect. CONTRIBUTING already requires one active implementation. A six-hour sweep plus assignment, reopen, and force will spawn Extra High on hosting tickets #4 and #6 the moment CURSOR_API_KEY exists. Automating the queue before anyone returns to Relay is the wrong work.
If this still merges, one code hole remains on latest f49d08f. I ran the exported skip against this head. No live Cursor launch.
Merge blocker
shouldSkipstill usescomments.body.includes(MARKER_PREFIX). Outsider<!-- relay-sykosyber-agent:anythingand a quoted prefix both skip launch. Skip only an exactmarkerFor(agentIdFor(issue.number))that starts agithub-actions[bot]comment. Cover those two negatives and a real bot marker staying idempotent. Do not call Cursor to prove the agent exists.
Previous CodeQL URL finding is resolved. CI on this head is green. That does not make the skip trusted.
Ponytail (not merge conditions, do not apply here)
.github/workflows/sykosyber-issues.yml:6 — delete: cron sweep; assignment plus workflow_dispatch is enough.
scripts/ci/launch-sykosyber-agent.mjs:14 — yagni: SHA1 UUID mint; Cursor can assign agentId, 409 already means reuse.
scripts/ci/launch-sykosyber-agent.mjs:85 — yagni: modelFromEnv; the workflow already hardcodes Extra High.
docs/delivery.md — shrink: the Extra High paragraph restates CONTRIBUTING.
Unblock
Close #43 and start Extra High by hand when Mateo picks an issue. If you insist on the workflow, the bot-author exact-marker skip is the only remaining code change.
| ) | ||
| ) { | ||
| return 'already launched'; | ||
| } |
There was a problem hiding this comment.
This skip still treats any comment body that contains MARKER_PREFIX as a successful launch. I reproduced it on this head: { body: '<!-- relay-sykosyber-agent:anything' } from an outsider, and a quoted marker in prose, both return already launched and never call Cursor.
The prefix and the deterministic agentIdFor(issue.number) are public. includes is enough for anyone with issue-comment access to suppress Extra High forever.
Minimum fix: skip only when a comment from github-actions[bot] starts with markerFor(agentIdFor(issue.number)). Do not ask Cursor whether the agent exists. Cover outsider prefix, quoted prefix, and a real bot marker remaining idempotent.
Better product call: close this PR. Assignment-triggered Extra High is a click saved, and it fights one-active-implementation.
|
Seth’s REQUEST_CHANGES 5123899009 is on exact
Extra High does not self-approve this PR and will not close it. Last-push partner review remains @sdcarlson. Extra High will not merge or deploy. |
|
Closing as deferred under the requested clean-base review. This issue-dispatch automation is not required for the Relay testing round or for Mateo to develop from current main; existing Cursor tasks can be started directly. The proposed assignment/reopen/sweep workflow also retains the reproduced untrusted-comment marker suppression bug and has not had a live authenticated launch verified. The separate two-account testing work already landed in #44. Keeping this optional automation open should not delay the clean testing base. Branch and commits are preserved; this is not a claim the marker bug is fixed. Revisit in a focused PR when this dispatch workflow is needed, with trusted-marker regressions and live setup evidence. Hosting issues #4/#6 remain separate and open. |
|
Closing this. Starting Extra High is a click, not a product defect. The workflow would also launch on hosting tickets #4 and #6 and fights one-active-implementation. The remaining skip bug still stands if this is reopened: Start Extra High by hand when an issue is picked. |
Problem and result
Mateo’s assigned issues (for example #4) waited for someone to start Cursor Grok 4.6 Extra High by hand. Cursor Automations have no issue-assignment trigger, so this change adds a repository-owned GitHub Action that launches Extra High as soon as
@sykosyberis assigned.Afterward, assigning Mateo comments the agent URL on the issue and starts an implementation agent from current
main. The issue stays open until the resulting pull request squash-merges withCloses #numberafter required CI and peer approval. Hosting or credential blockers stay open.This PR leaves issues 4 and 6 open. Those stay on the sweep once
CURSOR_API_KEYis set. Local two-account tests for issue 4 landed in #44.Evidence
pnpm lint, dispatch unit tests (7 passed). Latest hosted CI onf49d08f(merge ofmainincluding Prove two-account isolation in compiled and browser tests #44, run 34005699232): all 9 required checks passed. Prior green headsa879d1c(run 34004965669) and7b7e22d(run 34004533488). An earlier head failed CodeQL on a testincludesof an issue URL (fixed) and hit the intermittent production 503 atscripts/ci/run-production.mjs:222(Diagnose intermittent 503 in compiled production integration test #22).CURSOR_API_KEYfrom the Cursor dashboard. The Sykosyber implementation workflow does not appear on the Actions sidebar until this PR squash-merges intomain.nodescript, pinnedactions/checkout,persist-credentials: false, nosecrets: inherit, no Cloudflare/Access secrets. Issue bodies are wrapped as untrusted prompt text. No database change.Review
docs/public-copy.json; runpnpm public-copy:checkand followdocs/PUBLIC-COPY.mdwhen these change.Maintainer setup
CURSOR_API_KEYfrom https://cursor.com/dashboard/api