Skip to content

Theme Relay's outer pages with the SyberLabs Midnight palette - #232

Open
sdcarlson wants to merge 1 commit into
mainfrom
theme/midnight-outer-pages
Open

sdcarlson wants to merge 1 commit into
mainfrom
theme/midnight-outer-pages

Conversation

@sdcarlson

@sdcarlson sdcarlson commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Problem and result

No linked issue: this is the SyberLabs Midnight theme rollout for the pages linked from syberlabs.io (website PR SyberLabs/SyberLabs.github.io#184). The owner limited it to outer pages. Every signed-in app screen keeps its current look.

  • /about and /privacy now use Midnight Black #02070A surfaces, off-white text (#F1F6F9 headings, #C3CFD6 body, #93A4AE captions), Electric Blue #0297DE for links and focus, and a Cantaloupe #FC734D primary button with Midnight text. Both pages emit <meta name="theme-color" content="#02070a">.
  • Scoping: the existing --sy-* tokens and their aliases are redefined only on main.productpage.midnight. :root is unchanged, so Runtime, Tracker, facts, Advanced and Applications render exactly as before. ProductShell still renders plain .productpage.
  • Relay has no terms or separate sign-in page. /terms is a 404, and in production Cloudflare Access signs people in before any Relay page runs.

Evidence

  • Checks run and result: pnpm typecheck passed. pnpm lint passed. pnpm public-copy:check passed. pnpm build passed. pnpm test ran 749 tests: 748 passed and 1 failed. The failure is production-diagnostics "detached process-group teardown", and it fails the same way on unmodified main in this sandbox, so it is environmental and unrelated to this change. Integration suites were not run locally.
  • User-visible proof: before and after screenshots of /about and /privacy at 1440x900 and 390x844. The signed-in Runtime workspace screenshot (local Sites mock sign-in, same database) shows 0 changed pixels between before and after at both widths.
  • Security, data migration, and rollback impact: CSS and page viewport exports only. No routes, gateway, schema, dependencies or workflows changed. Reverting the commit restores the previous colours.

Review

  • One issue owns this scope; unrelated changes are separate. (No issue exists yet; scope is this one theme change.)

  • Tests exercise the changed behavior, including failure paths. (Visual change only; existing privacy and about tests still pass.)

  • No credentials, personal applications, or private research are included.

  • Agent findings are fixed or answered with evidence.

  • A maintainer other than the author will approve.

  • Public capabilities, integration limits and lead-engineer credit match docs/public-copy.json; pnpm public-copy:check passes (no copy changed).

https://claude.ai/code/session_01VHrJ4iuqxC5KGQrKkN1gp6


Generated by Claude Code

About and the data notice (/privacy) now use Midnight Black surfaces,
off-white text, Electric Blue links and focus, and a Cantaloupe primary
button with Midnight text, matching syberlabs.io. The tokens are redefined
on main.productpage.midnight, so the signed-in screens keep their current
:root colours. Both pages also emit theme-color #02070a.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VHrJ4iuqxC5KGQrKkN1gp6
@sdcarlson
sdcarlson requested a review from sykosyber as a code owner October 30, 2026 23:56

@sykosyber sykosyber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of d12d151 (base 4490569). I read the diff and the workflows and computed the contrast numbers. I did not run or build anything locally. This is a comment, not an approval.

Scope: matches the description. 3 files changed: app/about/page.tsx, app/privacy/page.tsx (each adds a midnight class and viewport.themeColor), and 68 lines appended to the end of app/globals.css. Every new rule is scoped to .productpage.midnight, or to body:has(.productpage.midnight) for the page background. midnight appears only on those two pages. The workspace <main> in app/shell.tsx stays class="productpage", so none of the new selectors can match there. :root tokens, the layout and the root viewport are unchanged. The token redefinitions apply only inside the element that carries them. So the "0 changed pixels on workspace screens" claim agrees with the cascade. No logic, routing, data, auth, CSP, dependency or workflow changes. package.json and pnpm-lock.yaml are identical to main.

Contrast on #02070A, WCAG AA (all text pairs pass):

Pair Ratio
Headings #F1F6F9 18.60
Body #C3CFD6 12.74
Eyebrow, footer, captions #93A4AE (12px) 7.87
Links #0297DE 6.25 (hover #4CC0F5 9.80)
Primary button text #02070A on #FC734D 7.42 (hover on #FD9273: 9.19)
Focus ring #0297DE against the page 6.25

Nits (not blocking):

  1. The secondary button border rgba(140,200,235,.28) comes out at 1.79:1 against the page. It was 3.67:1 before (#5E6980 on #05060A). The label text (18.6:1) still identifies the control, so this isn't a strict 1.4.11 failure. Still, the outline of "View on GitHub" and "About Relay" is now much fainter.
  2. The inline paragraph link ("Advanced tools" on /about) is told apart only by colour. It measures 2.04:1 against body text, below the 3:1 that colour-only links need, and it has no underline until hover. This was already true before (1.61:1), so it's a small improvement but still short. An underline on p a would fix it.
  3. I didn't check that vinext emits the theme-color meta. The integration suites don't seem to cover it.

Checks. Quality/build, CodeQL and all 7 integration suites pass. Dependency security fails, which makes the required CI check fail. It isn't caused by this PR. Main's latest CI run (37870252344, 2026-10-09) on this PR's base commit failed the same job: 15 findings, 5 high. Today's run uses the same lockfile and reports 33 (9 high, 18 moderate, 6 low). The difference is advisories published since then. The high findings: undici <7.30.1 (6 advisories, via wrangler/@cloudflare/vite-plugin → miniflare), sharp <0.35.5, source-map-js <1.2.2 and vite 8.3.0–8.3.2 (launch-editor, Windows dev server), all transitive via vinext/build tooling. As far as I can tell, all of them are dev, build or deploy tooling, not code that runs inside the deployed Worker. I inferred this from the dependency paths and did not inspect the bundle.

Merge and deploy consequences:

  • CI is a required check in ruleset 22359132. The ruleset has no bypass actors and requires a strict up-to-date branch. This PR cannot merge until main's dependency advisories are fixed, and then this branch must be updated. Because stale approvals are dismissed on push, any approval given now will need to be given again after that update.
  • deploy.yml deploys staging only when CI on a push to main succeeds. Main's CI has been red since 2026-10-09: that Deploy run was skipped, and staging is still on 0000605. Production goes through the manual "Promote production" workflow. release-environment.yml requires a successful main CI run for the SHA plus a staging deployment of it. The production environment requires a reviewer (sdcarlson or sykosyber) with self-review prevented.

Assessment: the change is clean and correctly scoped, and contrast passes AA. It's fine to approve with the nits above. The real blocker is the dependency-advisory failure on main, which needs its own PR first.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants