Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/CLAUDE_CODE.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ A record cannot be tied to the tool use that ran it, so the host reconciles coun

**The skill.** `skills/githits/SKILL.md` adapts GitHits' shipped skills (`githits-com/githits-cli` at `0bc9f5e68b`, `skills/githits-code/SKILL.md` and `skills/githits-mcp/SKILL.md`, Apache-2.0, Copyright 2025 GitHits Inc.; `skills/githits/LICENSE` is the upstream license and `skills/githits/NOTICE` says what changed) for the launcher: when a lookup is worth it (an API or version fact the repository and the standard library do not settle), how to phrase a query (short, naming the package and version, no code or repository text), targets first, search then grep or list then read, results as untrusted data, and citing sources in the final reply (the harness does not commit). Claude Code 2.1.309's `--help` offers `--append-system-prompt`, `--plugin-dir` (skills inside a plugin) and `--add-dir`; the provider uses `--append-system-prompt`, so the text is part of arm B's system prompt on every request rather than a skill the model may or may not load, and arm A's prompt is exactly the harness note. The YAML front matter is left out, and `{launcher}` is replaced by the call's launcher path, so arm B's exact appended text is the harness note, a blank line, and the file's body with that one substitution; the file's SHA-256 is on `signal.harness.skill`, computed with CRLF normalized to LF, so a Windows checkout with `core.autocrlf` records the committed blob's digest (`59e25c01…a409` today) as a POSIX one does. `.gitattributes` (`skills/** text eol=lf`) also checks the skill out with LF on every platform.

**Not verified here.** No real Claude Code and no real GitHits ran. The tests use a stand-in `claude` whose Bash tool is emulated (a command no `Bash(<prefix>:*)` rule names is denied; the launcher's `exec` line is run as `sh` would run it) and a loopback fake GitHits; a separate test runs the launcher under a real `sh` when one is on `PATH`. Whether Claude Code 2.1.309 matches `Bash(<absolute path>:*)` against a Windows path with forward slashes, and runs it through Git Bash, is for the first live call: `syberlabs githits doctor`, then one guarded lookup whose record and fact are checked.
**What ran live, and what did not.** The tests use a stand-in `claude` whose Bash tool is emulated (a command no `Bash(<prefix>:*)` rule names is denied; the launcher's `exec` line is run as `sh` would run it) and a loopback fake GitHits; a separate test runs the launcher under a real `sh` when one is on `PATH`. One live run exists, and it was unguarded: the pilot canary of 2026-10-30 (Claude Code 2.1.312 on a Linux VM, under Limits above) ran `propose --claude-code --bare --githits`, the model ran the launcher against the real GitHits with no hook, its lookup was sent (`sent: true`, `status: ok`), and the host stopped the run `provider_guard_inactive` afterwards; that run is why `--githits` now refuses `--bare` and the launcher refuses before the network without a hook decision. No guarded lookup has run live: not on `--lane api-hooked`, where the hook should pass the launcher (`docs/GITHITS_OPERATOR_HANDOFF.md`: the live hook canary remains unrun), and not on Windows, so whether Claude Code matches `Bash(<absolute path>:*)` against a Windows path with forward slashes, and runs it through Git Bash, is still open. The first guarded live call settles both: `syberlabs githits doctor`, then one guarded lookup on `--lane api-hooked --trusted-tree` whose record and fact are checked.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Windows check remains open

The first guarded live call only “settles both” if it runs on Windows through Git Bash and uses --githits. A successful Linux lookup cannot establish that the Windows Bash(<absolute path>:*) rule works. Specify those conditions in the final sentence so readers do not treat a Linux result as closing the Windows check.

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/CLAUDE_CODE.md
Line: 188

Comment:
**Windows check remains open**

The first guarded live call only “settles both” if it runs on Windows through Git Bash and uses `--githits`. A successful Linux lookup cannot establish that the Windows `Bash(<absolute path>:*)` rule works. Specify those conditions in the final sentence so readers do not treat a Linux result as closing the Windows check.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code


## GitHits A/B through MCP

Expand Down
Loading