Repository navigation
Security review: GitPush tree kill, README facts line, witness-backed verify - #172
Merged
Merged
Conversation
…ts line, witness-backed verify - GitPush: push and ls-remote run in their own session under a deadline that ends the whole tree (checks._stop), so a timed-out push no longer leaves ssh running. A timeout is still an unknown outcome. - README: the facts route line now says when it is refused (attestation_denied). - Verify history (Work.verify_history: GET /verify, syberwork verify) also reads the witness's log when configured, so a history rewritten and rehashed after a head was signed fails. Without a log it says the chain alone cannot see that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sykosyber
force-pushed
the
claude/security-followups-three
branch
from
November 4, 2026 05:15
5eae162 to
e168952
Compare
sykosyber
marked this pull request as ready for review
November 4, 2026 05:37
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: after #171, three items from the security review were still open. A
git_pushpublish that timed out endedgitbut left the transport it started (ssh) running. The README described the facts route as if any fact could be asserted. And Verify history checked only the hash chain, so a history the database owner rewrote and rehashed still showed as intact, even when the witness had signed the original head.After: a timed-out push or status read ends its whole process tree. The README's facts line says when the route refuses a key. Verify history also reads the witness's log when one is configured, so a history rewritten after a head was signed fails verification. Without a log, the response says that the chain alone cannot see a rehash.
Class: P
Agent-platform: claude
Admitted-by: sykosyber (Mateo approved merging on Nov 4)
What changed, by item
GitPush.applyand itsls-remotestatus read now run throughpublish._bounded: their own session (POSIX), output to a file, and a deadline that ends the tree throughchecks._stop(taskkill /T on Windows), as a publish command and a check already do. A timeout is still an unknown outcome (effect_unknown), as before.ls-remotekeepsRepo.git's scrubbed environment andcore.fsmonitor=false. Test:GitPushTimeoutEndsTheTree(a stand-in ssh viacore.sshCommandthat starts its own child; fails on main with the child still running).POST /api/cases/{id}/factsnow says it is refused (attestation_denied) for a key the contract reads, unless a required fact names that same source without asking for verification, matchingWork._attestable.Work.verify_history(case_id, log=None), used byGET /api/cases/{id}/verifyandsyberwork verify. With a witness log it judges the signed heads aswitness_statusdoes;validis false onhead_differs,beyond_historyorchain_broken. The response now carrieschain,witness(witnessed_through,count,conflicts, or null) and anote.validkeeps its meaning without a log. Tests:HistoryVerifiesAgainstTheWitness(Work level, in-process witness) andConsoleWitness.test_a_rehashed_history_passes_the_chain_but_not_verify(route). README,docs/ARCHITECTURE.mdanddocs/console/NOTES.mdsay what this covers and what it still doesn't.Behavior change to review
GET /verifyreturns more fields than{"valid": ...}. The console reads onlyvalid, so it is unchanged, but it now shows "does NOT verify" when a witness conflict exists. Fourtest_consoleasserts were updated from exact-dict tovalid/chain.Still not solved
Evidence (claim ceiling: Implemented and Tested)
conformance.run: matched 23 golden traces. G5: 0 protected spans changed. G6: ok.Generated by Claude Code