Repository navigation
Close the contamination, license, launcher and record bypasses an independent adversarial review found in the GitHits client and its Claude Code launcher before the A/B pilot. #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
219a677
Close bypasses an adversarial review found in the GitHits client and …
sdcarlson 40d98d0
Refuse a path, glob or prefix that names an excluded owner, never cra…
sdcarlson 1cab541
Name @name in bash_arguments' docstring among the words a shell reads…
sdcarlson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a failed or timed-out provider call leaves no client record, this creates a synthetic
githits.unrecordedfact, butmetrics._threadcounts everygithits.*fact exceptgithits.doctoras an authentic client record. Consequently, a journal containing only this placeholder reportsgithits_lookups.value = 1with the notehost-observed: authentic GitHits client records, even though the launcher may never have started the client. Update the metrics reader alongside this new fact type so missing records preserve an unknown count rather than becoming a definite measurement in the A/B results.Useful? React with 👍 / 👎.