Repository navigation
Delete dead code across the repo - #189
Merged
Merged
Conversation
providers/ (bring, managed, maxun, mcp, openapi, fromManifest), admission.ts, provider.ts, mcp.ts, mcpClient.ts and bring.ts were only imported by each other and their own tests; no production, script or e2e path reached them. Drops @modelcontextprotocol/client and @modelcontextprotocol/server with them. Tests that used the providers as fixture builders now seal manifests directly. DESIGN.md updated to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Remove test-only production code (searchApiIndex, exportSnapshot, getCapability/listCapabilities, routeWires, resolveBlockIcon, createLLMService, modelIntentCompiler, validateAllTemplates, ...) - Remove unreachable branches (create-intent destructive gate, polymarket/newsapi focus formatting, summaryOnly/timeWindow wire filtering) - Remove the write-only speech timing module and its plumbing - Remove unused aliases, getters, props, duplicate default exports, two unused index.ts barrels, a stale CSS variable and commented-out code - Make ~90 exports used only within their own file module-private Found per area and adversarially verified; typecheck, lint, tests and production build all pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes ~4,900 lines of dead code (175 files, +651/−4911), in two commits:
providers/(bring, managed, maxun, mcp, openapi, fromManifest),admission.ts,provider.ts,mcp.ts,mcpClient.tsandbring.ts. Only each other and their own tests imported these; no production, script or e2e path reached them. Drops@modelcontextprotocol/clientand@modelcontextprotocol/server. Tests that used providers as fixture builders now seal manifests directly. This commit passes typecheck, lint and tests on its own, so it can be reverted cleanly if the subsystem is still wanted.searchApiIndex,exportSnapshot,routeWires,resolveBlockIcon,createLLMService,modelIntentCompilerandvalidateAllTemplates.destructive: false)polymarket/newsapifocus formatting (real block IDs look likepolymarket_live_odds)summaryOnly/timeWindowwire filtering (nothing sets these options)How it was found
A knip pass, then per-area dead-code hunters with an adversarial verifier for each area. The verifiers rejected 6 candidates as live behavior: the MCP/async runtime binds in
execute.ts, the MindPanel Graph tab, the "Change Aesthetic" command and Polymarket resume. Those were kept.Test plan
npm run typecheckis cleannpm run linthas 0 errors and the same 5 warnings as beforenpm test: 1573 passed, 29 skippednpm run buildsucceeds🤖 Generated with Claude Code