Repository navigation
Midnight theme for the not-found page, the one outer page - #187
Merged
Merged
Conversation
Flyspace serves one page route: / opens straight into the canvas. The only site-like page a visitor can reach is the 404 that every other path returns, which was the framework's stock page (white in a light browser). It is now src/app/not-found.tsx with the same copy and layout in the SyberLabs Midnight palette, scoped to .midnight-page so the canvas and every working screen keep the Atlas palette (canvas screenshot before and after: 0 of 1,296,000 pixels differ). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHrJ4iuqxC5KGQrKkN1gp6
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective. Bring Flyspace's outer pages into the SyberLabs Midnight theme (syberlabs.io, SyberLabs.github.io #184) and leave every app screen exactly as it is.
What a visitor sees today. The app has one page route.
/(where syberlabs.io's "Open the preview" goes) opens straight into the canvas: no landing, welcome, sign-in, privacy, terms or about page exists. Sign-in goes to syberlabs.io (SIGN_IN_URL). The only site-like page this app serves is the 404 that every other path returns (/privacy,/terms,/about,/signinall 404), and it was the framework's stock page, black on white in a light browser.What changed.
src/app/not-found.tsx: the same 404 copy and layout as the stock page, plus<meta name="theme-color" content="#02070a">.src/app/globals.css: one block at the end, scoped to.midnight-page. It redefines the existing tokens (--citadel-void,--text-*,--rule*,--ice,--blue) to the Midnight values, setscolor-scheme: dark, Electric Blue links and focus, and Midnight selection. Text:#F1F6F9(18.6:1) and#C3CFD6(12.7:1) on#02070A.What did not change. The canvas, Shell Store, blocks, personas, sidebar, top bar, account panel and every other working screen. No
:roottoken changed. The OAuth callback page (/api/oauth/:provider/callback) is a transient popup and is untouched. No dependency, workflow, lockfile or deploy config changed.Tests run (local, Node 22).
npm run typecheck: 0 errors.npm run lint: 0 errors, 5 existing warnings.npm test: 1656 passed, 29 skipped (Postgres).npm run build: passes, plus CI'swrangler deploy --dry-run(the bundle'sindex.jsis written). Not run locally:test:e2eandscan:bundle, which CI runs.Measurements. I served the built Worker (
wrangler dev) and took Playwright Chromium screenshots. The 404 at 1440x900 and 390x844: bodyrgb(2,7,10), h1rgb(241,246,249), h2rgb(195,207,214), theme-color#02070a, no horizontal scroll. The empty canvas at 1440x900, before and after: 0 of 1,296,000 pixels differ.Known failures. None.
Claim ceiling. Tested locally against the Worker build. Not deployed.
Architectural decisions. A
.midnight-pagewrapper is the scope for any future site-like page, so the theme never reaches the canvas.Falsifiable by. Any canvas pixel changing, or a 404 that is not Midnight on the deployed host.
Next permissible package. Deploy by hand (
npm run deploy:vinextfrom a cleanmain; the deploy-preview workflow is off), then checkhttps://omni.syberlabs.io/privacyshows the Midnight 404.Generated by Claude Code