Repository navigation
Enable pinned docs search and OSS example grounding for agents - #171
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2f39a1c3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class: C
Agent-platform: codex
Admitted-by: Seth Carlson, explicit request to build Phase 2 agent grounding (technical canon)
Permit five named read-only tools on the existing private-accounted GitHits server: search, get_example, read, list and grep. CLAUDE.md requires exact lockfile versions, returned source citations, minimal public-only example queries and local verification. Retrieved material remains untrusted data. No wildcard tool permission, feedback/effectful tool, product dependency, token or direct hosted fallback is added.
Validation: all five project settings pass exact JSON allowlist conformance without provider requests. Local typecheck passes; lint has zero errors and five existing warnings. Live grounding remains unverified until normal authenticated agent use; missing credentials/indexing are stated explicitly.
Five-line status:
Pinned dependency documentation search is enabled in project settings.
OSS prior-art examples use minimal public-only queries.
Only five named read-only tools receive standing permission.
Existing private accounting and cache routing remain in place.
No live grounding result or provider credential setup is claimed.