Skip to content

FRED: show the notice and terms link its API terms require - #165

Merged
claude[bot] merged 1 commit into
mainfrom
wp/omni/fred-notice
Oct 13, 2026
Merged

claude[bot] merged 1 commit into
mainfrom
wp/omni/fred-notice

Conversation

@sykosyber

Copy link
Copy Markdown
Member

Objective. Meet FRED's API terms for an application other people use, so the owner can opt FRED into house keys (OMNI_HOUSE_KEYS=omni:fred) without breaching them.

What FRED requires (terms, read 2026-10-12): display a link to the terms; state that using the app means agreeing to them; and prominently show "This product uses the FRED® API but is not endorsed or certified by the Federal Reserve Bank of St. Louis."

What changed

  • curatedApis.ts: attribution on a curated entry (notice, termsUrl, termsTitle), set for FRED with its exact wording. attributionFor(manifest) matches on the API's origin (https://api.stlouisfed.org), so a FRED spec installed any way gets it.
  • ProviderAttribution.tsx: the notice and "Using this block means agreeing to the FRED® API Terms of Use" (link, noopener noreferrer). Not collapsible.
  • CapabilityBlock.tsx: pinned below the scrolling result, always visible, before and after a run. AddApiDialog.tsx: shown in the install review.
  • DEPLOYMENT.md: the house-key paragraph notes FRED's requirement is met and where.

What did not change. FRED's own data, the house-key rules, and other APIs (no attribution set).

Tests run

  • typecheck 0 errors; lint 0 errors (8 existing warnings).
  • npm test 1655 passed, 1 failed (fieldHarness.test.ts, known Windows-only CRLF).
  • New ProviderAttribution.component.test.tsx (3): every FRED operation and a FRED spec compiled without curation get it; Metaculus does not; the block shows the exact notice and the terms link before any run. AddApiDialog.component.test.tsx: the FRED review shows the notice.
  • npm run build + npm run scan:bundle PASS; npm run build:next + npm run test:e2e 9 passed.

Measurements. None.

Known failures. fieldHarness.test.ts on Windows only.

Claim ceiling. Implemented and tested with fixtures. Whether this satisfies FRED is FRED's call. The text follows its terms page word for word.

Architectural decisions introduced. Provider-required attribution lives on the curated entry and is matched by API origin.

Evidence that could falsify it. A FRED block that renders without the notice. Other FRED terms (no "FRED" in a hostname, no Fed logos) are deployment matters, not code.

Next permissible package. Owner: get a FRED key, set FRED_API_KEY and OMNI_HOUSE_KEYS=omni:fred on a private deployment, then a live house-key run.

🤖 Generated with Claude Code

FRED's API terms require an application other people use to show, in its
words, "This product uses the FRED® API but is not endorsed or certified by
the Federal Reserve Bank of St. Louis.", and to link the terms that using it
means agreeing to. Every FRED block now shows both, pinned below its result,
and so does the FRED install review. Matched on the API's origin, so a FRED
spec installed another way gets it too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sykosyber
sykosyber enabled auto-merge October 13, 2026 03:47
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T03:52:41.884822Z 69f64c7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 69f64c77ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@claude
claude Bot merged commit 7e23c5b into main Oct 13, 2026
5 checks passed
@claude
claude Bot deleted the wp/omni/fred-notice branch October 13, 2026 03:53
@github-actions

Copy link
Copy Markdown
Contributor

Codex feedback round 1 answered 1 of 1 Codex finding(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant