Repository navigation
FRED: show the notice and terms link its API terms require - #165
Conversation
FRED's API terms require an application other people use to show, in its words, "This product uses the FRED® API but is not endorsed or certified by the Federal Reserve Bank of St. Louis.", and to link the terms that using it means agreeing to. Every FRED block now shows both, pinned below its result, and so does the FRED install review. Matched on the API's origin, so a FRED spec installed another way gets it too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69f64c77ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex feedback round 1 answered 1 of 1 Codex finding(s). |
Objective. Meet FRED's API terms for an application other people use, so the owner can opt FRED into house keys (
OMNI_HOUSE_KEYS=omni:fred) without breaching them.What FRED requires (terms, read 2026-10-12): display a link to the terms; state that using the app means agreeing to them; and prominently show "This product uses the FRED® API but is not endorsed or certified by the Federal Reserve Bank of St. Louis."
What changed
curatedApis.ts:attributionon a curated entry (notice,termsUrl,termsTitle), set for FRED with its exact wording.attributionFor(manifest)matches on the API's origin (https://api.stlouisfed.org), so a FRED spec installed any way gets it.ProviderAttribution.tsx: the notice and "Using this block means agreeing to the FRED® API Terms of Use" (link,noopener noreferrer). Not collapsible.CapabilityBlock.tsx: pinned below the scrolling result, always visible, before and after a run.AddApiDialog.tsx: shown in the install review.DEPLOYMENT.md: the house-key paragraph notes FRED's requirement is met and where.What did not change. FRED's own data, the house-key rules, and other APIs (no attribution set).
Tests run
npm test1655 passed, 1 failed (fieldHarness.test.ts, known Windows-only CRLF).ProviderAttribution.component.test.tsx(3): every FRED operation and a FRED spec compiled without curation get it; Metaculus does not; the block shows the exact notice and the terms link before any run.AddApiDialog.component.test.tsx: the FRED review shows the notice.npm run build+npm run scan:bundlePASS;npm run build:next+npm run test:e2e9 passed.Measurements. None.
Known failures.
fieldHarness.test.tson Windows only.Claim ceiling. Implemented and tested with fixtures. Whether this satisfies FRED is FRED's call. The text follows its terms page word for word.
Architectural decisions introduced. Provider-required attribution lives on the curated entry and is matched by API origin.
Evidence that could falsify it. A FRED block that renders without the notice. Other FRED terms (no "FRED" in a hostname, no Fed logos) are deployment matters, not code.
Next permissible package. Owner: get a FRED key, set
FRED_API_KEYandOMNI_HOUSE_KEYS=omni:fredon a private deployment, then a live house-key run.🤖 Generated with Claude Code