feat(web): toggle day-prefix event jump with Shift - #2711
Merged
Conversation
Replace hold-Shift home-row chips with a Shift-tap jump mode that labels events by weekday prefix and per-day index, highlights the selected day column, and removes the old 1-7 column focus shortcuts. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Remove unused shift-hint aliases, update Playwright for Shift-tap day-prefix chips, and land review gaps (escape ownership, ambiguous digit commit, shortcut swallowing, exit announcement linger). Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Avoid hardcoding Wednesday at xRatio 0.42; the visible column varies with viewport width, so read chip prefixes from the overlay instead. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Schedule jump mode just past the double-tap window so Shift-Shift does not flash chips. Also skip activate under keyboard-only or with no targets, and strip ambiguous digit buffers on arrow/unmatched keys. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hold-Shift home-row jump chips with a Shift-tap toggle for day-prefix event jump. Week chips use
SU/M/T/W/R/F/SAplus a per-day index; Day view uses numeric chips. Day letters highlight the column and focus the first event; digits refine. Esc or another Shift tap exits. Shift+chords never toggle; Shift-Shift still enters keyboard-only without a jump flash (activation is deferred past the double-tap window). Week1–7column shortcuts removed.Simplicity
Extracted shared assignment/hint builders in
useShiftHoldEventHints, inlined one-use day-prefix helper, and flattened EventJumpIndicator copy. Retained document-level gesture refs/effects and the rebuild-on-event-set effect for stable chips.Automated validation
bun run knip/bun run lint: pass/week: chips, day letter + digits, Esc, Shift+J, Shift-Shift — all passIndependent review
Confirmed findings fixed (Escape ownership, weekend
Sabandon, ambiguous digit commit + buffer reset, shortcut swallowing, exit announcement linger, deferred activate for Shift-Shift, no activate under keyboard-only / empty targets).Test plan
bun packages/scripts/src/testing/test-parallel.ts web -- packages/web/src/shortcuts/shift-hint/ packages/web/src/shortcuts/keyboard-only/bun run knip·bun run lintbunx playwright test e2e/timed/shift-hold-event-hints.spec.ts e2e/timed/keyboard-only-mode.spec.tsShipped: merged as
576d8993→ tagv1.1.151; staging-cloud and staging-selfhosted health checks green.