Skip to content

Fix carthage build - #140

Open
gilroykilroy wants to merge 5 commits into
Swinject:masterfrom
gilroykilroy:master
Open

Fix carthage build#140
gilroykilroy wants to merge 5 commits into
Swinject:masterfrom
gilroykilroy:master

Conversation

@gilroykilroy

Copy link
Copy Markdown

Fix carthage build by checking in the generated Swift header file into the project. Perhaps some tweaking of search paths would solve the problem too but I could not figure that out.

@Lex-Nagtegaal

Copy link
Copy Markdown

when will this pull request be merged?

@yoichitgy

yoichitgy commented Jul 2, 2021

Copy link
Copy Markdown
Member

Thank you for making the PR😃 and sorry for taking too long to respond🙇‍♂️

I'm not sure we still see the issue when using Carthage.

@mpdifran

mpdifran commented Jul 4, 2021

Copy link
Copy Markdown
Member

Yeah I don't think this is necessary. The included ./carthage-build.sh helps get around the build issue when not using xcframeworks, and we'll add xcframework support in the next major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants