Add AWS native functionality#4083
Open
kcieplak wants to merge 1 commit into
Open
Conversation
kcieplak
commented
Jun 24, 2026
- Based on the configuration variable AWS_S3_DIRECT_ACCESS read build logs, documentation and readme files directly from S3, rather than the S3 web frontend.
- Add handling of root urls to map to index.html
- Based on AWS_USE_IAM_ROLE use instance roles to access S3 rather than access key/secret
- Based on ENABLE_PACKAGE_UPLOAD_PRESIGNED_URLS and ENABLE_BUILD_LOGS_PRESIGNED_URLS, create presigned URLs to pass to builders for logs and docs upload.
- Add functionality to the Dockerfile to be able to build spi in debug vs release
- Do not add back cookies in responses, the site does not use cookies.
- Make the gitlab project id for build triggers configurable via GITLAB_PROJECT_ID *
* Based on the configuration variable AWS_S3_DIRECT_ACCESS read build logs, documentation and readme files directly from S3, rather than the S3 web frontend. * Add handling of root urls to map to index.html * Based on AWS_USE_IAM_ROLE use instance roles to access S3 rather than access key/secret * Based on ENABLE_PACKAGE_UPLOAD_PRESIGNED_URLS and ENABLE_BUILD_LOGS_PRESIGNED_URLS, create presigned URLs to pass to builders for logs and docs upload. * Add functionality to the Dockerfile to be able to build spi in debug vs release * Do not add back cookies in responses, the site does not use cookies. * Make the gitlab project id for build triggers configurable via GITLAB_PROJECT_ID *
| ) | ||
|
|
||
| defer { | ||
| Task { |
Member
There was a problem hiding this comment.
This raises a warning
Unstructured throwing task created by 'init(name:priority:operation:)' is not used, which may accidentally ignore errors thrown inside the task
We have a construct
try await run { ... }
defer: {
try await client.shutdown()
}
(see above in the same file, line 63ff) in order to deal with async defer.
Member
There was a problem hiding this comment.
Having some issues getting tests to pass with this branch. I'll see if it's on my end and if there are any changes, I'll roll them all up into a PR on top of this PR rather than sprinkle lots of comments on this one here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.