Skip to content

Add AWS native functionality#4083

Open
kcieplak wants to merge 1 commit into
SwiftPackageIndex:mainfrom
kcieplak:add-aws-functionality
Open

Add AWS native functionality#4083
kcieplak wants to merge 1 commit into
SwiftPackageIndex:mainfrom
kcieplak:add-aws-functionality

Conversation

@kcieplak

Copy link
Copy Markdown
  • Based on the configuration variable AWS_S3_DIRECT_ACCESS read build logs, documentation and readme files directly from S3, rather than the S3 web frontend.
    • Add handling of root urls to map to index.html
  • Based on AWS_USE_IAM_ROLE use instance roles to access S3 rather than access key/secret
  • Based on ENABLE_PACKAGE_UPLOAD_PRESIGNED_URLS and ENABLE_BUILD_LOGS_PRESIGNED_URLS, create presigned URLs to pass to builders for logs and docs upload.
  • Add functionality to the Dockerfile to be able to build spi in debug vs release
  • Do not add back cookies in responses, the site does not use cookies.
  • Make the gitlab project id for build triggers configurable via GITLAB_PROJECT_ID *

* Based on the configuration variable AWS_S3_DIRECT_ACCESS
  read build logs, documentation and readme files directly
  from S3, rather than the S3 web frontend.
  * Add handling of root urls to map to index.html
* Based on AWS_USE_IAM_ROLE use instance roles to access
  S3 rather than access key/secret
* Based on ENABLE_PACKAGE_UPLOAD_PRESIGNED_URLS and
  ENABLE_BUILD_LOGS_PRESIGNED_URLS, create presigned URLs
  to pass to builders for logs and docs upload.
* Add functionality to the Dockerfile to be able to build
  spi in debug vs release
* Do not add back cookies in responses, the site does not
  use cookies.
* Make the gitlab project id for build triggers configurable
  via GITLAB_PROJECT_ID
*
@SwiftPackageIndex SwiftPackageIndex deleted a comment from cla-bot Bot Jun 24, 2026
)

defer {
Task {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This raises a warning

Unstructured throwing task created by 'init(name:priority:operation:)' is not used, which may accidentally ignore errors thrown inside the task

We have a construct

try await run { ... }
defer: {
   try await client.shutdown()
}

(see above in the same file, line 63ff) in order to deal with async defer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having some issues getting tests to pass with this branch. I'll see if it's on my end and if there are any changes, I'll roll them all up into a PR on top of this PR rather than sprinkle lots of comments on this one here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants