Repository navigation
Shooter Subsystem Rework: Remove Existing Shooter Subsystem - #113
Open
CanineSatsuma6 wants to merge 1 commit into
Open
CanineSatsuma6 wants to merge 1 commit into
CanineSatsuma6 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is one of several in a series of PRs designed to rework our shooter subsystem to address issues with maintainability and readability and reintroduce some semblance of simplicity. Any PR that's merging into the
shooter-subsystem-reworkbranch and NOTmainis a part of this series.This PR begins the process of reworking the shooter subsystem by deleting the existing implementation. This includes:
NetParamsmechanism as the only parameters that were supported were related to the shooter subsystemRobotContainer.javato better isolate default commands and button assignments into their own methodsShooterConstantsclass into the existingVisionConstantsclass