fix(feature): scope Aeon watermark to dev-loop test runs only - #77
Merged
Merged
Conversation
The watched branch's "Built autonomously by Aeon" footer and the external branch's "Built by Aeon" footer were unconditional, so every production PR (real contributions, not pipeline tests) carried AI attribution branding regardless of context. Drop the watched-branch footer entirely - it's never dispatched as part of a chain, so it's always production output. Gate the external-branch footer on $AEON_DISPATCH_ID, which is only set when chain-runner dispatches the run (currently only the dev-loop chain, i.e. an Aeon Engineer self-test) - standalone external runs now ship with no watermark. Claude-Session: https://claude.ai/code/session_016xbBGRZZNLpo3XeMqrEzNA
Svector-anu
commented
Sep 12, 2026
| [What prompted this — issue, TODO, code review finding, etc.] | ||
|
|
||
| ${AEON_DISPATCH_ID:+<!-- aeon-dispatch:$AEON_DISPATCH_ID -->} | ||
| ${AEON_DISPATCH_ID:+<!-- aeon-dispatch:$AEON_DISPATCH_ID -->}${AEON_DISPATCH_ID:+ |
Owner
Author
There was a problem hiding this comment.
[ISSUE] This head currently fails the required ci-skill-integrity / verify gate; rebase after #78 (which removes the pre-existing RCE-PIPE-EXEC trigger) and confirm the check turns green. Why it matters: the watermark behavior cannot be merged or exercised through the protected path while required verification is red.
Svector-anu
commented
Sep 12, 2026
Svector-anu
left a comment
Owner
Author
There was a problem hiding this comment.
Verdict: discussion-needed
The code path looks coherent, but the required integrity gate is currently failing.
Findings (mirrored as inline comments):
- [ISSUE] skills/feature/SKILL.md:353 — this head fails required integrity verification, so it needs a rebase after #78 and a green rerun before merge.
…scanner RCE-PIPE-EXEC fix + lockfile regen for eyebrow gate
…ow RCE-PIPE-EXEC fix (#78)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Changes
skills/feature/SKILL.md§A8: dropped the watched-branch footer entirely.skills/feature/SKILL.md§B7: gated the external-branch footer on$AEON_DISPATCH_ID, which chain-runner only sets when a chain dispatched the run - currently that's only thedev-loopchain (feature → pr-review), i.e. an Aeon Engineer self-test. Standalone/manual/scheduled external runs now ship with no watermark.Context
Requested after reviewing PR #76 (the dev-loop chain's first real dogfood run): "built by aeon is okay, but only when we are testing the aeon engineer." Production contribution PRs should read like normal engineering work; the watermark should only signal a self-test of the pipeline itself.