Skip to content

feat: add adaptive_concurrency_interval to settings UI formatting labels - #634

Open
SuperCoolPencil wants to merge 4 commits into
mainfrom
fix/adaptive-concurrency-interval-units
Open

SuperCoolPencil wants to merge 4 commits into
mainfrom
fix/adaptive-concurrency-interval-units

Conversation

@SuperCoolPencil

@SuperCoolPencil SuperCoolPencil commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Improvements
    • Settings now display appropriate unit suffixes, including seconds, minutes, data rates, connections, retries, and ratios.
    • Duration settings support clearer editing in either seconds or minutes.
    • The adaptive concurrency interval displays and edits using a clear raw-seconds format.
    • Settings consistently use their configured units for display and editing.
    • Unit labels and authentication-token text are easier to read with improved contrast.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: d778cbef-bab1-4a69-b9a8-e34e92c9b9da

📥 Commits

Reviewing files that changed from the base of the PR and between aea2471 and 7dd8052.

📒 Files selected for processing (1)
  • internal/tui/view_settings.go

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The configuration schema now defines setting units and propagates them through metadata. The TUI uses those units for suffixes, edit formatting, and value conversion. Duration settings support seconds and minutes.

Changes

Settings unit metadata and TUI formatting

Layer / File(s) Summary
Unit metadata contracts
internal/config/settings_schema.go, internal/config/settings.go
SettingUnit constants and the Setting.Unit field define supported units. Default settings assign units, and metadata copies them for TUI use.
Unit-driven TUI formatting
internal/tui/view_settings.go, internal/tui/update_settings.go
The TUI uses units instead of setting keys to render suffixes, format edit values, and convert submitted values.
Duration unit validation
internal/tui/settings_unit_test.go
Tests cover duration suffixes, seconds and minutes formatting, and minute-based duration conversion.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Suggested reviewers: junaid2005p

Sequence Diagram(s)

sequenceDiagram
  participant SettingSchema
  participant SettingMeta
  participant SettingsTUI
  participant setSettingValue
  SettingSchema->>SettingMeta: define and propagate Unit
  SettingMeta->>SettingsTUI: provide unit metadata
  SettingsTUI->>SettingsTUI: render suffix and format edit value
  SettingsTUI->>setSettingValue: submit unit-formatted input
  setSettingValue-->>SettingsTUI: update setting value
Loading

Merge Risk: ⚪ Minimal · up to 7dd80

The migrated settings preserve their existing display and edit behavior, so this change is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the adaptive concurrency interval formatting change, which is part of the settings UI unit-formatting updates. It is specific and related to the pull request.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Binary Size Analysis

⚠️ Size Increased

Version Human Readable Raw Bytes
Main 18.09 MB 18972964
PR 18.10 MB 18977060
Difference 4.00 KB 4096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant