Repository navigation
feat(phase61): open in editor / show in Finder (Plan 061) - #90
Merged
Merged
Conversation
Hand files and projects to the user's real editor instead of building one. Agent-reported paths are untrusted, so the Rust command resolves them inside the project (symlinks and .. followed, regular files only) and always opens with the named editor via `open -a`, never the default handler that would execute .command/.app targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014UA3Dk8XywNUyaR3MV5tzP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who live in VS Code want to see the whole file an agent touched, not just the staged diff, and won't adopt a tool that hides their files. Phase 61 hands files and projects to the user's real editor instead of building one in-app.
open_in_editor(Rust). Agent-reported paths are untrusted: they're canonicalized and must be regular files inside the project, so.., absolute outside paths, and out-pointing symlinks are rejected. Opens viaopen -a <editor>with an exit-status check, never the default handler (which would execute.command/.apptargets). No capability change.editor_appsetting (default Visual Studio Code) with inline error recovery and a "change editor" link.OpenInEditorcomponent in the diff pop-out and on the dashboard project view's path line: Show in Finder · Open in editor · change editor. The empty-diff copy now points to Open in editor for the whole file.Validation: macOS built-app checks 104–110 passed, including the exploit check: an executable
x.commandopened as text in VS Code and TextEdit, and/tmp/pwnwas never created. The editor setting survived a restart. Detailed evidence is indocs/TESTING.md.Automated gates passed on the committed tree:
npm run check,npm run opencode:check,npx tsc --noEmit,cargo test --lib(180 passed, 1 ignored, including 3 newresolve_insidetests),cargo clippy --all-targets -- -D warnings, andgit diff --check.npm run buildpassed before the final button-order change, and again after it. No extraction prompt changed, so golden was not run.Not verified: the non-macOS fallback (opener plugin, detached, so a missing editor may fail silently), which is tracked in the ROADMAP Windows gap table. Codex's UI fixtures left 28 labeled synthetic events for a
/private/tmpscratch project in the maintainer's local DB; archive it on the dashboard if it appears.User's unrelated
.logic-loop/board.mdedit and the Plan 062 draft are excluded from this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_014UA3Dk8XywNUyaR3MV5tzP