This repository was archived by the owner on Mar 23, 2025. It is now read-only.
Bug/save null value#12
Open
nqztv wants to merge 2 commits into
Open
Conversation
Prevents a runtime error when match.TourneyName is null. If there is no tourney name, use the match description instead.
Instead of just inserting the whole match description into the tournament attribute if tourneyname is null, just insert the first part of the description.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to a Smashboards user ATranimal (https://smashboards.com/threads/skillkeeper-trueskill%E2%84%A2-rankings-bookkeeper.376590/page-8#post-21702319), the Save As feature is still broken. I confirmed the error and copied the fix from the Save function to the Save As function. I also changed it so it doesn't copy the whole match description if a tournament name is not found, just the first part of the match description.