Create real PDF signature fields#167
Merged
Merged
Conversation
15108fa to
0afd913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes FormFyxer PDF export so
FieldType.SIGNATUREfields are emitted as real AcroForm signature fields (/FT /Sig) instead of text fields.Also declares the
uvdev dependency group expected by the sharedSuffolkLITLab/ALActions/pythontestsworkflow so CI can installmypy,pytest, and FormFyxer runtime imports before running checks.Root cause
ReportLab does not expose a signature widget API, so FormFyxer created signature placeholders with
form.textfield(). That preserved placement, but external PDF editors correctly interpreted the result as a text field.The CI failure happened because the shared action runs
uv sync --group devwhen[dependency-groups]exists and then callsuv run mypy; FormFyxer did not previously declare uv-managed dev dependencies.Changes
/SigFlagswhen signature fields are created.FormFieldobjects.devdependency group for the shared uv-based CI action.Validation
uv sync --group devexport PYTHONPATH=$PYTHONPATH:$PWD; uv run mypy . --exclude '^build/' --explicit-package-basesuv tool run bandit -r . --exclude './scripts,./venv,./.venv,./build' --severity-level=highexport PYTHONPATH=$PYTHONPATH:$PWD; uv run pytest -qpython -m py_compile formfyxer/pdf_wrangling.py formfyxer/tests/test_pdf_labeling_rules.pygit diff --checkGitHub Actions passed on commit
0afd913.