Conversation
Fix error not printing when missing sources paths
plocket
changed the title
cwd aswell as the base for file paths to integrate with ALKiP changes,cwd as well as the base for file paths to integrate with ALKiP changes,
plocket
commented
Apr 19, 2026
plocket
commented
Apr 19, 2026
BryceStevenWilley
approved these changes
May 5, 2026
BryceStevenWilley
left a comment
BryceStevenWilley
left a comment
Collaborator
There was a problem hiding this comment.
Looks great to me!
Co-authored-by: Bryce Willey <Bryce.Steven.Willey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix error not printing when missing sources paths. [Until this is merged, some changes in ALKiP can't be implemented.]
Implements some of the changes currently in #1041 and will conflict with that PR.
In this PR, I have:
Reason for this PR
ALKiP needs to change the way it handles its filepaths. I believe this new need is because of the different environments (e.g. S3 or not, etc.) it's in and the files in now needs to manage to deal with concurrency lock timeout issues. This started a long time ago, though, and my memory is fuzzy. It might simply be an ALKiP enhancement.
Links to any solved or related issues
None
Any manual testing I have done to ensure my PR is working
Ran locally, ran with ALKiP.