Keep approved device polling resilient - #18
Merged
Conversation
Signed-off-by: Pavel Tkachyk <p.tkachyk.by@gmail.com>
Signed-off-by: Pavel Tkachyk <p.tkachyk.by@gmail.com>
Contributor
Author
|
Fixed the critical review finding in |
Signed-off-by: Pavel Tkachyk <p.tkachyk.by@gmail.com>
Signed-off-by: Pavel Tkachyk <p.tkachyk.by@gmail.com>
Signed-off-by: Pavel Tkachyk <p.tkachyk.by@gmail.com>
Contributor
Author
|
Adversarial review found one critical diagnostic-containment/status-precedence issue; fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production evidence
For the latest approved grant, the last successful server-side poll remained 1.096 seconds before approval across two Hermes retries. Four subsequent
/oauth/tokenrequests ended instarlette.requests.ClientDisconnectwhile_formawaited the body, consistent with the v2.0.2 15-second client timeout. The approved grant was never consumed.Validation