Apply wicked core changes and backend on upstream v1.31.1 - #17
Merged
Stumble merged 2 commits intoSep 9, 2026
Conversation
Add primary-schema facts and scoped schema conventions, retain parameter context inference and fix repeated-relation ambiguity, and expose the minimal backend protocol. Include core tests, release version plumbing, secure toolchain/dependencies, and core CI/test tooling. No wicked generation implementation or dispatch is included in this commit.
Add the standalone wicked generator, legacy Go mappings and runtime templates, CLI dispatch, generation/consumer regression fixtures, bookstore CI, and usage documentation. Preserve the previously verified product tree while presenting the fork as exactly two linear commits on upstream v1.31.1.
This was referenced Sep 9, 2026
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply the wicked fork directly on upstream sqlc v1.31.1 in exactly two
linear commits, with no merge commit or imported upstream history in the PR range.
This supersedes the merge-based review in #16. It reorganizes the verified
implementation, not the product behavior.
Base and the two commits
Base
integration/upstream-v1.31.1is initialized to the exact upstream commita95e91d70ad9e1181253c333a1cfdd75ae4b95a5(v1.31.1).4739a8ac5— core changes41bb4c158— wicked backendinternal/codegen/wicked: Go types, templates, comment options, cache keys,timeout, invalidation, transaction and replica behavior.
The old
refactor/upstream-syncbranch is retained. No force-push or change tomainis involved, and this PR is in Stumble/sqlc, not sqlc-dev/sqlc.Merging it updates the integration branch; promoting/replacing the legacy main
branch remains a separate decision.
Verification
aa0ff2cdbtree:1c3c895c10634e2292636bbe68b17370f673bd61.and historical Markdown trailing whitespace. Product source, dependencies,
protocol, templates, generated files and CI configuration are byte-identical.
consumer/JSON fixture tests; bookstore
sqlc diffpass.CGO/non-CGO builds, bookstore runtime/race, and zero reachable vulnerabilities.
same-input wicked v2.3.4 output except version comments.
its regenerated source differs from its checked-in source only by comments,
and that source commit has passing CI. Trex local full compilation remains
unverified due to CCXT exceeding the environment memory soft limit.
Compatibility and remaining work
Existing wpgx entrypoints and validated generated contracts are retained.
The fork's internal plugin protocol changes; old custom plugin binaries are not
a compatibility target. Qualified built-in type recognition and the documented
compiler fixes remain intentional improvements.
The top-level SELECT classification is not a full read-only proof. Ordinary-view
primary models, wicked batch/last-ID and database-only analysis remain unsupported;
copyfrom retains its existing cache/invalidate limitation.
No production migrations or downstream runtime dependency upgrades. Generic
patches remain in this fork; an actual upstream contribution is a separate task.
Related PR
Runtime example and regression suite: Stumble/bookstore#2.
The full design/history and verification record is in
docs/changelogs/2026-09-08-sync-upstream-and-separate-wicked-codegen.md.