feat(worker): keep publish history across publish-only retries (U8) - #22
Merged
Merged
Conversation
withPublishSummary moves a summary it replaces into publish_history (at most the last five, oldest first) so a retry no longer erases the stop code, failures, and repair rounds of the run before it (R15). History is the first thing dropped to stay within MaxResultBytes, oldest entry first. A first publish, replacing the "not_attempted" string, adds none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 57 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements U8 (requirement R15) of the factory-quality follow-ups plan in PR #21.
What changed
withPublishSummary(internal/worker/publish.go): when thepublishvalue it replaces is already a summary object, that object is appended to apublish_historyarray (oldest first) before the new summary is written. Only the last 5 entries are kept."not_attempted"string, adds no history.protocol.MaxResultBytes, history entries are dropped oldest first before the existing degradations (droppingphases, then the minimal verdict). If history empties, the key is removed.Verification
just checkpasses (format, vet, boundary, definitions, full test suite, build).internal/worker/publish_ci_test.go:publishgreen, one history entry carryingci_failed, the redci_refand the failing check; first publish has no history;ci_repair_exhaustedand its pushed round;phases, sets notruncated, and keeps the current verdict.Mutation results (each compiled under
go vet; all killed)not_attemptedstring) added to historyNot covered
🤖 Generated with Claude Code