test: give Git subprocesses a deterministic fixture identity - #13
Merged
Merged
Conversation
Reuse gitIdent in freshEnv so real Git children do not fall back to hostname-based identity detection while user/system configuration is disabled. Verify commit and reflog identities under poisoned inherited settings without relying on a DNS timeout.
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
freshEnv()disabled user/system Git configuration without supplying the fixture identity already used bygit(). Real Git commands launched by Herdr stubs could therefore fall back to hostname-based identity detection during commits and reflog writes.Reuse
gitIdentinfreshEnv(), keeping explicit overrides last. Add a regression that launches a real Git-writing stub from a child with poisoned inherited identity/configuration, then verifies the resulting commit author/committer and branch reflog identity.user.useConfigOnlymakes missing identity fail deterministically; the test does not simulate or claim to reproduce the reported DNS stall.Validation:
npm run validatepasses on Node 24: all 245 tests, source/manifest checks, and ShellCheck. The new regression failed with missing identity before the fix and passes afterward. Test-only change; plugin version remains 0.3.0.Fixes #11