Skip to content

Auto-prune and deleteInstallation bypass the _deleting per-row guard #145

Description

@Zaldaryon

PR #136 added a per-row _deleting flag to prevent double-dispatch when the user clicks the trash button twice. Two other code paths remove backup archives without checking this flag:

  1. The auto-prune loop at backup.ts:117-126 removes excess archives on a timer.
  2. deleteInstallation with the "delete data" option removes all backups for that installation.

Both can race with a user-initiated delete on the same row, producing the same false-failure toast #136 fixed for the button path. BackupRecord would need the field before the prune could even check it, so a broader design pass is needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions