Skip to content

Suppress 9 pre-existing ESLint/DeepSource sonarjs errors - #3387

Merged
Crabcyborg merged 1 commit into
masterfrom
fix/issue-3385-suppress-sonarjs-errors
Sep 18, 2026
Merged

Crabcyborg merged 1 commit into
masterfrom
fix/issue-3385-suppress-sonarjs-errors

Conversation

@vivi-the-going-merry

Copy link
Copy Markdown
Contributor

Closes #3385

Broken: 9 pre-existing sonarjs ESLint errors (jQuery.inArray and pre-existing regex usages) failing ESLint/DeepSource: JavaScript, surfaced while triaging #3378.

Changed: inline eslint-disable-next-line at each site, per the issue's decision to suppress rather than refactor. No behavior change.

One correction to the issue's own site list: the third super-linear-regex occurrence is js/src/admin/admin.js:2549, not js/formidable.js:2549js/formidable.js only has two (896, 2287). Re-derived all 9 sites by running a standalone eslint + eslint-plugin-sonarjs@4.2.1 (matching this repo's package.json version) against the current files rather than trusting the issue's line numbers, since the issue's own numbers are a snapshot that can drift.

Verified: re-ran the same standalone eslint+sonarjs check after the edits — 0 remaining sonarjs/prefer-native-jquery-alternative/sonarjs/super-linear-regex findings across all 5 files, no new "unused eslint-disable" warnings. Didn't run this repo's own npx eslint (no npm ci locally per policy) — CI's ESLint/DeepSource jobs are the real check.

🤖 Generated with Claude Code

Inline eslint-disable-next-line at each flagged site (jQuery.inArray
and pre-existing regex usages), per triage decision to suppress
rather than refactor. Underlying jQuery/regex code unchanged.

One site listed in the issue as js/formidable.js:2549 is actually
js/src/admin/admin.js:2549 (re-verified all 9 line numbers against a
standalone eslint + eslint-plugin-sonarjs run, not the issue's
snapshot numbers).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Strategy11/formidable-forms/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: edbbb304-bdc2-4547-8e2f-08cba09ae6ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 18, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in fc48e47...1b49999 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Sep 18, 2026 10:17p.m. Review ↗
JavaScript Sep 18, 2026 10:17p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg Crabcyborg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

🚀

@Crabcyborg
Crabcyborg merged commit 34d8b77 into master Sep 18, 2026
40 of 44 checks passed
@Crabcyborg
Crabcyborg deleted the fix/issue-3385-suppress-sonarjs-errors branch September 18, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suppress 9 pre-existing ESLint/DeepSource sonarjs errors

1 participant