Suppress 9 pre-existing ESLint/DeepSource sonarjs errors - #3387
Conversation
Inline eslint-disable-next-line at each flagged site (jQuery.inArray and pre-existing regex usages), per triage decision to suppress rather than refactor. Underlying jQuery/regex code unchanged. One site listed in the issue as js/formidable.js:2549 is actually js/src/admin/admin.js:2549 (re-verified all 9 line numbers against a standalone eslint + eslint-plugin-sonarjs run, not the issue's snapshot numbers). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Strategy11/formidable-forms/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP | Sep 18, 2026 10:17p.m. | Review ↗ | |
| JavaScript | Sep 18, 2026 10:17p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
Closes #3385
Broken: 9 pre-existing
sonarjsESLint errors (jQuery.inArray and pre-existing regex usages) failing ESLint/DeepSource: JavaScript, surfaced while triaging #3378.Changed: inline
eslint-disable-next-lineat each site, per the issue's decision to suppress rather than refactor. No behavior change.One correction to the issue's own site list: the third
super-linear-regexoccurrence isjs/src/admin/admin.js:2549, notjs/formidable.js:2549—js/formidable.jsonly has two (896, 2287). Re-derived all 9 sites by running a standaloneeslint+eslint-plugin-sonarjs@4.2.1(matching this repo'spackage.jsonversion) against the current files rather than trusting the issue's line numbers, since the issue's own numbers are a snapshot that can drift.Verified: re-ran the same standalone eslint+sonarjs check after the edits — 0 remaining
sonarjs/prefer-native-jquery-alternative/sonarjs/super-linear-regexfindings across all 5 files, no new "unused eslint-disable" warnings. Didn't run this repo's ownnpx eslint(nonpm cilocally per policy) — CI's ESLint/DeepSource jobs are the real check.🤖 Generated with Claude Code