Skip to content

Lift the admin footer text off the grey it could not be read against - #3377

Merged
Crabcyborg merged 1 commit into
masterfrom
footer-a11y
Sep 18, 2026
Merged

Crabcyborg merged 1 commit into
masterfrom
footer-a11y

Conversation

@tuguirazvan

Copy link
Copy Markdown
Collaborator

--grey-400 measures 2.58:1 on the white admin body. The footer text is 12px, so it is normal text and answers to 4.5:1 — --grey-500 is the lightest stop on the ramp that clears it, at 4.97:1. The social icons take the same step.

The social links also had no hover feedback: their resting rule and .frm_wrap a:hover are both (0,2,1) and this file loads later, so the grey won. The added pseudo-class settles it at 600, with :focus-visible alongside so the affordance is not mouse-only.

Token bumps only — no palette values changed. Built CSS diff is three footer rules and nothing else.

PROD-5662's missing-accessible-name half was already fixed on master in 8bb0bee28; this covers the contrast half.

🤖 Generated with Claude Code

grey-400 measures 2.58:1 on the white admin body. The footer text is 12px,
so it is normal text and answers to 4.5:1; 500 is the lightest stop on the
ramp that clears it, at 4.97:1. The social icons take the same step.

The social links also had no hover feedback: their resting rule and
.frm_wrap a:hover are both (0,2,1) and this file loads later, so the grey
won. The added pseudo-class settles it at 600, and :focus-visible rides
along so the affordance is not mouse-only.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 369f71bc-fd4b-419a-a080-26ea276b7506

📥 Commits

Reviewing files that changed from the base of the PR and between 6b8e650 and a3fd4da.

📒 Files selected for processing (2)
  • css/frm_admin.css
  • resources/scss/admin/components/_admin_footer.scss

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 18, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 6b8e650...a3fd4da on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Sep 18, 2026 2:30p.m. Review ↗
JavaScript Sep 18, 2026 2:30p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@Crabcyborg Crabcyborg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Razvan!

🚀

@Crabcyborg Crabcyborg added this to the 6.36 milestone Sep 18, 2026
@Crabcyborg
Crabcyborg merged commit 3030efe into master Sep 18, 2026
20 checks passed
@Crabcyborg
Crabcyborg deleted the footer-a11y branch September 18, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants