Fix invalid aria-selected on payment settings tab label

[vivi-the-going-merry]

What was broken

IBM Equal Access's aria_attribute_valid rule flagged a violation in the Cypress a11y run (tests/cypress/e2e/admin-a11y.cy.js, formidable-settings page). The CI log only records rule id/level/message, not a selector, so this was traced statically: classes/views/frm-settings/payments.php's payment-gateway tab <label> sits inside a role="tablist" container but carries aria-selected with no role of its own. aria-selected is only valid on option/tab/row/gridcell/treeitem/columnheader/rowheader — a bare <label> has no implicit ARIA role, so the attribute was invalid on it.

What changed

Added role="tab" to the label's attributes, matching the semantic intent (it's a clickable tab inside a tablist) and making aria-selected valid on the element that carries it.

How it was verified

Markup-only, single attribute addition — no CSS/JS change. Traced statically to the single element on the tested pages pairing an explicit role with a mismatched aria-* attribute; everything else co-occurring on the spec's target pages (dashboard, form list, entries, styles, applications, templates, import, settings, addons, smtp, trash) was already spec-valid. This PR's own CI run (admin-a11y.cy.js against formidable-settings) is the self-test for the fix.

Closes Strategy11/formidable-pro#6701

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a795e4a0-def7-4626-a8ed-d493f696bdd5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[deepsource-io]

DeepSource Code Review

We reviewed changes in e404085...85c9537 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade

Security   Reliability   Complexity   Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		Sep 18, 2026 12:17a.m.	Review ↗
JavaScript		Sep 18, 2026 12:17a.m.	Review ↗

---

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

[Crabcyborg]

Looks good!

🚀