Skip to content

A11y: group the captcha-type radio buttons on Global Settings - #3371

Open
vivi-the-going-merry[bot] wants to merge 1 commit into
masterfrom
fix/issue-6699-captcha-radio-grouping
Open

vivi-the-going-merry[bot] wants to merge 1 commit into
masterfrom
fix/issue-6699-captcha-radio-grouping

Conversation

@vivi-the-going-merry

@vivi-the-going-merry vivi-the-going-merry Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

What was broken

The recaptcha/hcaptcha/turnstile radio set on Formidable's Global Settings > Captcha tab had no programmatic grouping — assistive tech couldn't announce them as a related set (IBM Equal Access input_checkboxes_grouped, flagged by the Cypress a11y run in formidable-pro).

What changed

classes/views/frm-settings/captcha/captcha.php: added role="radiogroup" to the existing wrapper div, with aria-labelledby pointing at the existing "Select Captcha Type" heading (given a matching id). Markup-only — no fieldset/legend (would add unwanted browser chrome), no CSS or JS changes. Same pattern already used elsewhere in this codebase, e.g. classes/views/frm-fields/front-end/gdpr/gdpr-field.php.

How it was verified

Reproduced and confirmed locally via a disposable formidable-preview-env instance (Playground CLI) — before the fix, the rendered Global Settings page carried no role="radiogroup"/role="group" on this wrapper; after, role="radiogroup" appears exactly once with a correctly-resolving aria-labelledby reference, and the page's total line count is unchanged (no other markup/visual side effects). The repo's own cy.checkIbmAccessibility assertion is non-blocking in CI (assertCompliance(false), see formidable-forms#3356), so this couldn't be confirmed via a CI red/green signal.

Closes Strategy11/formidable-pro#6699

🤖 Generated with Claude Code

The recaptcha/hcaptcha/turnstile radio set on the Global Settings > Captcha
tab had no programmatic grouping, so assistive tech couldn't announce them
as a set (IBM Equal Access input_checkboxes_grouped). Add role="radiogroup"
to the existing wrapper, referencing the existing heading via
aria-labelledby. No fieldset/legend (avoids default browser chrome), no CSS
or JS changes.
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2e56aaac-cab5-4d41-82f1-2de035a39d71

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@deepsource-io

deepsource-io Bot commented Sep 17, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in e404085...5baa664 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Sep 17, 2026 11:52p.m. Review ↗
JavaScript Sep 17, 2026 11:52p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants