Skip to content

Fix invalid label for= references on the styles page (IBM label_ref_valid) #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivi-the-going-merry wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −23
Open

Fix invalid label for= references on the styles page (IBM label_ref_valid) #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c28023d
Fix invalid label for= references on the styles page (IBM label_ref_v…
vivi-the-going-merry[bot] Sep 17, 2026
2c6ba34
Drop the now-dead frm_field_shape id key
vivi-the-going-merry[bot] Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions classes/views/styles/_field-sizes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Width', 'formidable' ); ?></la
?>
</div>
<div class="frm5 frm_form_field">
<label
for="frm_field_pad"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field">
Expand All @@ -92,8 +91,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Padding', 'formidable' ); ?></
?>
</div>
<div class="frm5 frm_form_field">
<label
for="frm_field_margin"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field">
Expand All @@ -110,8 +108,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Margin', 'formidable' ); ?></l
?>
</div>
<div class="frm5 frm_form_field">
<label
for="frm_border_radius"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field">
Expand Down
3 changes: 1 addition & 2 deletions classes/views/styles/_general.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Center Form', 'formidable' );
?>
</div>
<div class="frm5 frm_form_field">
<label
for="frm_style_class"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Style Class', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field frm-style-component">
Expand Down
22 changes: 7 additions & 15 deletions classes/views/styles/_quick-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Button Text', 'formidable' );
<hr class="frm12"/>

<div class="frm5 frm_form_field">
<label
for="frm_field_margin"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Vertical Spacing', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field">
Expand All @@ -139,8 +138,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Vertical Spacing', 'formidable
</div>

<div class="frm5 frm_form_field">
<label
for="frm_field_pad"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Input Field Padding', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field">
Expand All @@ -160,8 +158,7 @@ class="frm-style-item-heading"><?php esc_html_e( 'Input Field Padding', 'formida
</div>
<hr class="frm12"/>
<div class="frm5 frm_form_field">
<label
for="frm_base_font_size"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Base Font Size', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field">
Expand Down Expand Up @@ -189,25 +186,21 @@ class="frm-style-item-heading"><?php esc_html_e( 'Base Font Size', 'formidable'
<hr class="frm12"/>

<div class="frm5 frm_form_field">
<label
for="frm_field_shape"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Field Shape', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field frm-sm-z-index">
<?php
new FrmFieldShapeStyleComponent(
$frm_style->get_field_name( 'field_shape_type' ),
$style->post_content['field_shape_type'],
array(
'id' => 'frm_field_shape',
)
array()
);
?>
</div>

<div class="frm5 frm_form_field frm_hidden" data-frm-element="field-shape-corner-radius">
<label
for="frm_border_radius"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Corner Radius', 'formidable' ); ?></label>
</div>
<div class="frm7 frm_form_field frm_hidden frm-md-z-index" data-frm-element="field-shape-corner-radius">
Expand Down Expand Up @@ -274,8 +267,7 @@ class="frm-style-item-heading">
?>
</div>
<div class="frm3 frm_form_field">
<label
for="frm_style_class"
<label
class="frm-style-item-heading"><?php esc_html_e( 'Style Class', 'formidable' ); ?></label>
</div>
<div class="frm9 frm_form_field frm-style-component" id="frm_style_class_custom_css" data-css-scope="<?php echo esc_attr( 'frm_style_' . $style->post_name ); ?>">
Expand Down
Loading