Run PHPUnit CI against WP trunk - #3360
vivi-the-going-merry[bot] wants to merge 2 commits into
Conversation
Fixes test_FrmStylesController::test_front_head on trunk: wp_head()'s wp_maybe_inline_styles() can't find wp-commands' dist stylesheet because develop.git.wordpress.org's tree only holds source, not build output. Add an npm build:dev step (matching WP core's own CI) before running PHPUnit, matrix wordpress: 6.9 -> trunk.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
setup-node's node-version-file resolves relative to GITHUB_WORKSPACE, so an absolute path outside the checkout doesn't work.
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP |  |
Sep 17, 2026 3:49p.m. | Review ↗ |
| JavaScript | |
Sep 17, 2026 3:49p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
What was broken
.github/workflows/phpunit.ymlpins the WP version matrix to6.9. A priorattempt to test against trunk (#1624, 2024) was reverted in Dec 2025 because
test_FrmStylesController::test_front_headfailed there.Root cause
Not a Formidable bug.
wp_head()'swp_maybe_inline_styles()checks thepathfor every enqueued style with apathextra, including core'swp-commandsstylesheet.develop.git.wordpress.org's tree only holdssource, not the built
wp-includes/css/dist/commands/style.min.cssfile -that's generated by
npm run build:dev, which this workflow never runs.Missing the file trips
wp_maybe_inline_styles()'s own incorrect-usagenotice, which
WP_UnitTestCaseconverts to a test failure. WP core's ownCI (
reusable-phpunit-tests-v3.yml) always builds this before testing.What changed
wordpress: 6.9->wordpress: trunk(both PHP legs).npm ci && npm run build:devstep against thecloned
/tmp/wordpresstree, before PHPUnit runs.How verified
CI run on this PR (trunk matrix + build step) - see checks.
Closes Strategy11/formidable-pro#6688.