Skip to content

Underline links inside .frm-text-xs help text #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vivi-the-going-merry wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −1
Open

Underline links inside .frm-text-xs help text #3350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ad448
Underline links inside .frm-text-xs help text
vivi-the-going-merry[bot] Sep 16, 2026
55872ca
Move new rule next to its sibling link styles; exclude icon+text CTAs
vivi-the-going-merry[bot] Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion css/frm_admin.css
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions resources/scss/admin/components/links/_link-styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ a.frm-link-secondary {
text-decoration: underline;
}

// Small (.frm-text-xs) help text often relies on a slightly muted color for
// its inline links, which can fall below the contrast ratio color alone
// needs against the surrounding text -- underline them so the link doesn't
// rely on color as its only cue. Excludes icon+text CTA links (e.g. "Connect
// Account"), which already have their own distinct treatment.
.frm-text-xs a:not(.frm-link-with-external-icon) {
text-decoration: underline;
}

.field_type_list li.button.frm_noallow,
.field_type_list li.button.frm_noallow:hover,
.button.frm_noallow,
Expand Down
Loading