Requested by: @Crabcyborg
On PR #3378 (branch fix_e2e_tests_failing → master), ESLint now passes but 2 Cypress e2e specs still fail:
1. tests/cypress/e2e/Forms/searchFunctionality.cy.js
Test: "should search valid and invalid form title"
CypressError: Timed out retrying after 4000ms: `cy.type()` failed because this element:
<input type="search" id="entry-search-input" name="s" placeholder="" class="frm-search-input" data-tosearch="">
is being covered by another element:
<html class="wp-toolbar" lang="en-US">...</html>
cy.type() on #entry-search-input is blocked because something (likely the WP admin toolbar / an overlay) sits on top of it at the time the test runs. Needs either a wait for the right element/animation state before typing, or the toolbar overlap needs fixing at the source — don't just slap {force: true} on without checking why it's covered first.
2. tests/cypress/e2e/Entries/deleteEntries.cy.js
Test: "Entries submitted from a form > should be verified and deleted" (fails both attempts, 1 of 2 retries)
AssertionError: Timed out retrying after 4000ms: expected '<a.frm_add_field>' to be 'visible'
This element <a.frm_add_field> is not visible because its parent <div#wpbody-content> has CSS property: overflow: hidden and an effective width and height of: 1280 x 0 pixels.
at Context.eval (webpack://formidable/./tests/cypress/e2e/Entries/deleteEntries.cy.js:20:54)
#wpbody-content is rendering at 0 height when the test tries to click .frm_add_field, so the element is present but not visible. Likely a page-load/render timing issue (assertion firing before the page has laid out), not a missing element — check what deleteEntries.cy.js:20 is doing right before this click and what it's waiting on.
What's needed
Fix both specs so PR #3378's e2e suite passes, then push to fix_e2e_tests_failing (or open a follow-up PR against it) so Michael can get #3378 merged.
Requested by: @Crabcyborg
On PR #3378 (branch
fix_e2e_tests_failing→master), ESLint now passes but 2 Cypress e2e specs still fail:1.
tests/cypress/e2e/Forms/searchFunctionality.cy.jsTest: "should search valid and invalid form title"
cy.type()on#entry-search-inputis blocked because something (likely the WP admin toolbar / an overlay) sits on top of it at the time the test runs. Needs either a wait for the right element/animation state before typing, or the toolbar overlap needs fixing at the source — don't just slap{force: true}on without checking why it's covered first.2.
tests/cypress/e2e/Entries/deleteEntries.cy.jsTest: "Entries submitted from a form > should be verified and deleted" (fails both attempts, 1 of 2 retries)
#wpbody-contentis rendering at 0 height when the test tries to click.frm_add_field, so the element is present but not visible. Likely a page-load/render timing issue (assertion firing before the page has laid out), not a missing element — check whatdeleteEntries.cy.js:20is doing right before this click and what it's waiting on.What's needed
Fix both specs so PR #3378's e2e suite passes, then push to
fix_e2e_tests_failing(or open a follow-up PR against it) so Michael can get #3378 merged.