reintegrating changes from chromadeck#305
Merged
Unreal-Dan merged 10 commits intosparkfrom Mar 11, 2026
Merged
Conversation
Unreal-Dan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is mostly ready now just needs some testing, there is still some weirdness with the VL sending but it might just be the shape of my orbit casing causing the duo receiving to pickup extra blinks.
Either way the VL sender component of spark is not heavily used, and this fixes the bug with the modesharing not working if you leave while sending.
It also fixes other things like the VL receiving now works with new protocol, good for sending a mode to llol.
should merge this soon but I did want to do a little more testing of the VL stuff to see if I could improve it, but not a big deal if that doesn't get done.