Repository navigation
chore(deps): clear audit advisories, bump ESLint 10, drop Node 18 - #20
Merged
Merged
Conversation
Contributor
Author
Second-model review
Verdict: approve. In plain EnglishApiGate's development tools carried two known security warnings, and its tests still ran on Node 18, which no longer gets security fixes. This change updates those tools, clears both warnings, and makes Node 20 the oldest supported version, with tests now running on Node 20, 22, 24 and 26. The scanner's own behavior does not change. One caveat remains: Node 20 has also been out of support since April 2026, so a later change may raise the minimum again. |
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13
What changed
npm audit fix(without--force) clears both high advisories, which were dev-only.brace-expansionmoves from 1.1.16 to 5.0.13.js-yaml4.3.0 leaves the tree: only@eslint/eslintrcrequired it, and ESLint 10 no longer installs that package.acorn8.17.0 to 8.19.0 (^8.19.0) andyaml2.9.0 to 2.9.1 (^2.9.1). No other runtime entry inpackage-lock.jsonchanged.eslint^10.15.0,@eslint/js^10.0.1,globals^17.14.0.eslint.config.mjsneeded no change. ESLint 10 addspreserve-caught-errortoeslint:recommended. It flagged three rethrows in tests, which now pass{ cause: e }(test/filter.mjstwice,test/gate.mjsonce); no test logic changed.engines.nodeis>=20inpackage.jsonand in the lockfile root. The CI matrix moves from 18, 20, 22 to 20, 22, 24, 26. Per the Node.js release schedule, 26 has been the Active LTS since 2026-10-28 and 24 has been in maintenance since 2026-10-20.README.mdanddocs/index.htmlnow read ≥20.CHANGELOG.mdgets an[Unreleased]entry.Proof per acceptance criterion
npm audit --audit-level=high: onmain, 2 high (brace-expansion,js-yaml) and exit 1; on this branch,found 0 vulnerabilitiesand exit 0.npm run lint && npm testpass on Node 22 and 24 (see Gate). Golden and determinism tests are unchanged:git diff --stat origin/main -- test/lists onlytest/filter.mjsandtest/gate.mjs, the three{ cause: e }arguments above."20", andnode -p "require('./package.json').engines.node"prints>=20.Gate
npm ci && npm run lint && npm testat 217f7ee:N passed, 0 failed.Node 20 and 26 are not installed locally; this PR's CI runs them.
Notes
>=20, so this PR follows it. Raising the floor to 22 would be a separate decision.^20.19.0 || ^22.13.0 || >=24. ApiGate itself runs on any Node 20, butnpm run lintneeds 20.19 or later. CI's"20"resolves to the newest 20.x.grep -c '"hasInstallScript": true' package-lock.jsonprints 0)..github/workflows/publish.ymlis unchanged and keeps Node 22. No version bump.Suggested labels: enhancement