Skip to content

docs: remove links to private Stelnyx repositories - #19

Merged
danieloceno merged 1 commit into
mainfrom
docs/12-private-repo-links
Nov 15, 2026
Merged

danieloceno merged 1 commit into
mainfrom
docs/12-private-repo-links

Conversation

@danieloceno

Copy link
Copy Markdown
Contributor

Closes #12

What changed

Link targets only; the text around them is unchanged.

  • The @stelnyx/report-theme links now point at its npm page, https://www.npmjs.com/package/@stelnyx/report-theme (CONTRIBUTING.md:10, DESIGN_PARITY.md:8).
  • The LuxScope and LuxFaber links now point at https://stelnyx.com/ (README.md:24, DESIGN_PARITY.md:5-6, docs/index.html:319-320). The issue allowed replacing or removing them; replacing keeps the sentences and the footer layout as they are.

Proof per acceptance criterion

  • git grep -nE 'github.com/Stelnyx/(LuxScope|LuxFaber|report-theme|web)' prints 7 lines on main and nothing on this branch (exit 1).
  • npm run lint && npm test pass (see Gate).
  • Task 3, every other github.com/Stelnyx/ link still in the repo:
Link target Visibility (gh api repos/Stelnyx/<repo>) Action
Stelnyx/ApiGate, Stelnyx/apigate (this repository) public left as is
Stelnyx/SecGate (served as Stelnyx/secgate) public left as is

Stelnyx/report-theme, Stelnyx/LuxScope, Stelnyx/LuxFaber and Stelnyx/web are private, and none of them is linked any more. npm view @stelnyx/report-theme version prints 0.1.4, so the new link points at a public package. https://stelnyx.com/ answers 200.

Gate

npm ci && npm run lint && npm test at 2d1f003, Node v22.23.4: exit 0. eslint reports nothing; all 20 suites end N passed, 0 failed.

Not done

  • No CHANGELOG entry and no version bump: this only fixes links in the docs.
  • DESIGN_PARITY.md:4-6 still shows local checkout paths such as (~/code/StelNyx/luxfaber) next to the links. Removing them would change copy, which this issue leaves out.

Suggested labels: documentation

@danieloceno

Copy link
Copy Markdown
Contributor Author

Second-model review

  1. nit (pre-existing, out of scope), DESIGN_PARITY.md:4-6: the sister-tool lines still carry local checkout paths such as (~/code/StelNyx/luxfaber), which mean nothing to a public reader. They were there before this change. Fix: drop them in a later docs pass; removing them changes copy, which Remove dead links to private repositories #12 leaves out.
  2. nit (out of scope), README.md:24 and docs/index.html:319-320: LuxScope and LuxFaber now both link to the same homepage, https://stelnyx.com/. The issue allows it. Fix: point each at its own product page once those pages exist.
  3. Verified: git grep -nE 'github.com/Stelnyx/(LuxScope|LuxFaber|report-theme|web)' prints nothing (exit 1); it printed 7 lines before the change. Every remaining github.com/Stelnyx/ link points at this repository or at SecGate, both public, and Stelnyx/LuxScope is still private. The npm registry answers 200 for @stelnyx/report-theme. The diff touches four docs files only (CONTRIBUTING.md, DESIGN_PARITY.md, README.md, docs/index.html) and changes link targets, not text. There are no test files, no CHANGELOG entry and no version bump. npm run lint && npm test on Node v22.23.4 exits 0, and all 20 suites end N passed, 0 failed.
  4. Security: no concerns. The change only edits link targets, adds no external domain the docs did not already link (both npmjs.com and stelnyx.com were linked before), and stops sending readers to private repository URLs.

Verdict: approve.

In plain English

ApiGate's public pages linked to three Stelnyx repositories that are private, so every visitor who clicked them got a "page not found" error. The links now go to the public npm page of the shared report theme and to the Stelnyx website, and the text around them is unchanged. Two small cosmetic leftovers remain: old local folder paths in one design note, and two products that share one homepage link. Neither breaks anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dead links to private repositories

1 participant