Refactor image building to use committed source and a release workflow#62
Merged
Conversation
- Updates CI workflows to stop pushing release tags on main - Adds new release.yml workflow for tagged releases - Commit generated source code (for reproducible builds) - Move initializr-related logic from build.ps1 to update-project.ps1 - Includes Spring Boot and dependency version bumps
- remove SslTrustConfiguration vestiges - trim comments and audit variable names
- download gradle-wrapper.jar as-needed in build.ps1 - use a shared workflow for building images - put all tag and revision logic in release.yaml, drop ADDITIONAL_TAGS
|
To run the UAA Server image built for this pull request: docker run --rm -d --pull=always -p 8080:8080 --name uaa-server-pr steeltoe.azurecr.io/uaa-server:pr-62 |
|
To run the Spring Boot Admin Server image built for this pull request: docker run --rm -d --pull=always -p 9099:9099 --name spring-boot-admin-pr steeltoe.azurecr.io/spring-boot-admin:pr-62 |
|
To run the Spring Cloud Config Server image built for this pull request: docker run --rm -d --pull=always -p 8888:8888 --name config-server-pr steeltoe.azurecr.io/config-server:pr-62 |
|
To run the Spring Cloud Netflix Eureka Server image built for this pull request: docker run --rm -d --pull=always -p 8761:8761 --name eureka-server-pr steeltoe.azurecr.io/eureka-server:pr-62 |
- add smoke tests to release workflow and for UAA - move port and health check path to metadata files - include /customizations/ in triggers - use customization for new file rather than patch (remove potential silent failure condition) - more consistent PowerShell formatting - Expand README.md, trim AGENTS.md to agent-specific content - also clear REVISION when the image version is changing
bart-vmware
requested changes
Jun 9, 2026
bart-vmware
left a comment
bart-vmware
left a comment
Member
There was a problem hiding this comment.
Initial feedback. Great improvements!
Could you please indicate which files are auto-generated and don't need to be reviewed?
bart-vmware
reviewed
Jun 9, 2026
This comment was marked as resolved.
This comment was marked as resolved.
workflows: - fewer path triggers - incorporate changes from #61, ensure use of latest major versions of all actions - update local var casing in workflows, along with step names and order update script: - temp_update_$Name -> $imageDirectory/workspace - $PSNativeCommandUseErrorActionPreference = $true, try/catch instead of $LASTEXITCODE - logging tweaks - support space-separated server/dir names in $Names param Mark **/source/** as generated code
TimHess
force-pushed
the
infra/build-refactor
branch
from
51b7f4f to
69025f6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bart-vmware
requested changes
Jun 10, 2026
Co-authored-by: Bart Koelman <104792814+bart-vmware@users.noreply.github.com>
- move smoke tests to shareable .ps1 - add param for smoketest with build.ps1 - expand all pwsh ternary usage to full blocks update-project.ps1 - document usage with multiple specified images - drop `ValueFromRemainingArguments` usage - adjust uaa readme header - throw instead of Write-Error (and dead-code return) - log if $bomVersionKey wasn't matched in build.gradle
bart-vmware
reviewed
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main