Decouple functions from fields namespace - #2
Merged
Conversation
Surprisingly fields and functions share a namespace. There can't be a function called "len" if a field "len" is also present. This happens exactly in hyperion. ElfMmapEvent has a len field, so registering a function fails there. It's a footgun. Luckily with a simple fix. Put function and field names in separate lookup maps. The lexer knows to use the function lookup map if the name is followed by (.
Collaborator
Author
|
CI fails on lint and whatnot but I tested this with hyperion |
ted-gould
approved these changes
Jun 25, 2026
ted-gould
left a comment
ted-gould
left a comment
There was a problem hiding this comment.
Don't see anything wrong with the code. But, is there a test suite we could add to? Seems like that'd help for these type of fixes.
Collaborator
Author
|
Yeah I agree. I'm adding some unit tests in hyperion but wirefilter could use them too. I'll have to add them if I ever get to upstream this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surprisingly fields and functions share a namespace. There can't
be a function called "len" if a field "len" is also present.
This happens exactly in hyperion. ElfMmapEvent has a len field,
so registering a function fails there.
It's a footgun. Luckily with a simple fix.
Put function and field names in separate lookup maps. The lexer
knows to use the function lookup map if the name is followed by (.